-
g089h515r806 →
committed f86105f0 on 8.x-1.x authored by
igork96 →
Issue #3002515 by igork96, vdenis, ankithashetty, kbrodej: Coding...
-
g089h515r806 →
committed f86105f0 on 8.x-1.x authored by
igork96 →
- Status changed to Needs work
over 1 year ago 12:10pm 3 June 2023 - 🇨🇳China g089h515r806
The patch is not works with latest code.
There still a lot coding standard message after I commit part of the patch.
https://www.drupal.org/pift-ci-job/2679552 → - 🇮🇳India arpitk
HI I worked on some phpcs errors/warning fixes on the latest code. Still there are few issues need to be fixed. Please review.
Thanks!
-
g089h515r806 →
committed 05bd7e0b on 8.x-1.x authored by
arpitk →
Issue #3002515 by arpitk, g089h515r806: Coding standards
-
g089h515r806 →
committed 05bd7e0b on 8.x-1.x authored by
arpitk →
- 🇨🇳China g089h515r806
committed. I made some changes for FieldValidationRuleBase:
public function setFieldName($field_name) { $this->fieldName = $field_name; return $this; }
and
public function setErrorMessage($error_message) { $this->errorMessage = $error_message; return $this; }
- 🇨🇳China g089h515r806
After change from field_name to fieldName, there are 26 test fails.
I change it back.
Even Drupal core use field_name instead of fieldName, it is not a coding standard issue. - Assigned to arti_parmar
- Assigned to RohitRawat676
- Status changed to Active
over 1 year ago 11:58am 2 August 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:03pm 2 August 2023 - last update
over 1 year ago 198 pass -
g089h515r806 →
committed 52cbda8c on 8.x-1.x authored by
RohitRawat676 →
Issue #3002515 by RohitRawat676: Coding standards
-
g089h515r806 →
committed 52cbda8c on 8.x-1.x authored by
RohitRawat676 →
-
g089h515r806 →
committed 0383237d on 8.x-1.x
Issue #3002515 by g089h515r806: Coding standards
-
g089h515r806 →
committed 0383237d on 8.x-1.x
-
g089h515r806 →
committed 05e213ea on 8.x-1.x
Issue #3002515 by g089h515r806: Coding standards
-
g089h515r806 →
committed 05e213ea on 8.x-1.x
- Status changed to Fixed
over 1 year ago 3:14am 16 August 2023 - 🇨🇳China g089h515r806
Mark this as fixed to give Credit to contributor.
there are only 31 coding standard messages. Good enough. Automatically closed - issue fixed for 2 weeks with no activity.