Fix the issues reported by phpcs

Hi urvashi_vora

I applied your coding-standard-fixes.patch → and after running the PHPCS command, it displayed the errors below

contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig paragraphs_sets/

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/paragraphs_sets/paragraphs_sets.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | [ ] Global constants should not be used, move it to a class or interface
123 | ERROR | [x] Use null coalesce operator instead of ternary operator.
180 | ERROR | [x] Use null coalesce operator instead of ternary operator.
228 | ERROR | [x] Use null coalesce operator instead of ternary operator.
574 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "paragraphs_set_load" but expected "paragraphs_sets_paragraphs_set_load"
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 693ms; Memory: 14MB

Please also look at the screenshot attached for your reference

Thanks

Resolved PHPCS issues reported for the module & raised MR https://git.drupalcode.org/project/paragraphs_sets/-/merge_requests/8

HI @agunjan085 I reviewed the MR in #5. It seems to resolve issues however still some errors are produced that need to be addressed.

Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js .

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/paragraphs_sets-3361247/paragraphs_sets.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | Global constants should not be used, move it to a class or interface
574 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "paragraphs_set_load" but expected "paragraphs_sets_paragraphs_set_load"
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Hi @arpitk
I have fixed the mentioned issues in https://git.drupalcode.org/project/paragraphs_sets/-/merge_requests/8 please review again

Hi agunjan085

I applied your updated MR !8 to my local and I confirmed that it fixes all the PHPCS issues.

Please look at the screenshot attached for your reference

Thank you

Thanks for your help.
I've changed some minor parts of the merge request (e.g. leaving function paragraphs_set_load() but deprecating it so other modules using it won't break).