๐Ÿ‡ฎ๐Ÿ‡ณIndia @agunjan085

Account created on 27 August 2019, about 5 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Hi mlncn,
Addressed the requested changes. Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Sure mlncn will make the changes as requested

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

agunjan085 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Hi @Andrew,

Kindly give the credit as the fix is working fine as tested.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Reviewed The patch. Do not see any reference to the function contextual_pre_render_links.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Applied changes from https://git.drupalcode.org/project/easyqrcodejs/-/merge_requests/1/diffs in drupal 10 site was able to see the QR code after applying the changes.

PFA

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Fixed issues listed in Phpcs. Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Hi AkashKumar07

I applied your patch 3333260-20.patch to my local and I confirmed that it fixes all the PHPCS issues.

Please look at the screenshot attached for your reference

Thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Hi @arpitk
I have fixed the mentioned issues in https://git.drupalcode.org/project/paragraphs_sets/-/merge_requests/8 please review again

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Hi @Yuezhu Please use the diff from MR https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/10 for testing instead of the patch as it was an old patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

I have verified MR https://git.drupalcode.org/project/modules_info/-/merge_requests/5 on Drupal9 as on Drupal10 i was facing https://www.drupal.org/project/modules_info/issues/3366016 ๐Ÿ› Modules info page unaccessible, Error: QueryException: Entity queries must explicitly set whether the query should be access checked or not. Needs review

I was able to add dummy machine names before.
After taking the MR code on save it is not letting us save dummy module machine name.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

agunjan085 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Verified the MR https://git.drupalcode.org/project/enable_disable_node_toggle/-/merge_re... on drupal 10 site
Issue faced before applying MR changes:
Able to add enable/disable toggle on comments, user view
On click of toggle ajax throwing error

After applying changes:
enable/disable toggle not available on view other than content views
Ajax error resolved

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Added checks for the states array in the Soap webform handler

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Verified the MR https://git.drupalcode.org/project/colorpalette/-/merge_requests/2
I am able to install module in Drupal 10
Able to add color & color filter tags taxonomy
Created entity reference field in content type & able to select the added color there

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

I have raised MR https://git.drupalcode.org/project/shield/-/merge_requests/12.
I am able to install the module in Drupal 10 & configure the same
Able to see the shield as well
Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Added core jquery library to the libraries.yml to resolve the console js error for anonymous user. Now the popup is working fine for both anonymous as well as admin user
Issue commit : https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/...

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

I am able to see the block after enabling the module
I have taken changes from https://git.drupalcode.org/project/partial_page_print/-/merge_requests/1 in my system and i was able to install the module successfully & able to see the print button block.
I am able to see the print button as well on the page & its working fine

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

The websote is throwing "website encountered an unexpected error" after enabling the module
I have taken changes from https://git.drupalcode.org/project/simple_password_policy/-/merge_reques... in my system and i was able to install the module successfully & resolve the temporarily unavailable error.
I am able to see the configure button as well after the module is installed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

The module is throwing an error when i am trying to enable it
I have taken changes from https://git.drupalcode.org/project/ab_age_gate/-/merge_requests/2 in my system and i was able to install the module successfully.
I am able to see the configure button as well after the module is installed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

Will be testing the MR on Drupal 10 website

๐Ÿ‡ฎ๐Ÿ‡ณIndia agunjan085

I have tried the code changes mentioned in https://git.drupalcode.org/issue/simple_popup_blocks-3350919/-/tree/3350...
The issue is not occuring when logged in as admin & the popup is working fine as expected but its throwing error in console when opening site as anonymous user. Attaching patch for the same

Production build 0.71.5 2024