- Issue created by @Maithri Shetty
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:32pm 24 May 2023 - last update
about 1 year ago 8 pass, 2 fail The last submitted patch, 2: Drupal_calls_should_be_avoided_in_classes_use_dependency_injection_instead_3362478_2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Assigned to sourabhjain
- Status changed to Needs work
about 1 year ago 5:13am 25 May 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:11am 25 May 2023 - last update
about 1 year ago 8 pass, 2 fail - 🇮🇳India sourabhjain
I have fixed the test case failing issue. Please review.
The last submitted patch, 6: 3362478-6.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Assigned to agunjan085
- Status changed to Needs work
about 1 year ago 9:35am 25 May 2023 - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @agunjan085 opened merge request.
- last update
about 1 year ago 8 pass, 2 fail - 🇮🇳India agunjan085
I have raised MR https://git.drupalcode.org/project/shield/-/merge_requests/12.
I am able to install the module in Drupal 10 & configure the same
Able to see the shield as well
Please review - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:13am 6 June 2023 - Status changed to RTBC
about 1 year ago 8:41am 6 June 2023 - 🇮🇳India nidhi27
I have tested #MR12 on Drupal 10.1.0 version. It has successfully removed \Drupal calls and added the dependency as well. Functionality also working as expected. Attaching the screenshot for the reference.