Contrib.social

Return validation errors in the request language

Open on Drupal.org →
Created on 7 February 2025, about 2 months ago

Problem/Motivation

Currently the messages returned in WebformSubmissionValidationError.messages are always in English. We should return them in the request language so users can see the messages in their chosen language.

Proposed resolution

Leverage StringTranslationTrait and rework all the messages in the WebformSubmit data provider.

Before:

$result->addError(sprintf('Webform %s does not exist.', $id));

After:

$result->addError((string) $this-t('Webform @id does not exist.', ['@id' => $id]));

Remaining tasks

  • Make all the messages translatable.
  • Add a test.
✨ Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @pfrenssen
  • Comment about 2 months ago →
    🇮🇳India agunjan085
  • Comment about 2 months ago →
    🇧🇬Bulgaria pfrenssen Sofia

    Thanks @agunjan085 for picking this up! Just a heads up, this is an issue intended for the 2.x-dev branch, but the merge requests are still made for the old 8.x-1.x branch. Please make sure you are working on the right branch!

    Unfortunately I do not have the right permissions to fix the default branch in Gitlab.

  • Merge request !55Resolve #3505042 "Return validation errors" → (Open) created by ankitv18
  • First commit to issue fork.
  • Comment about 2 months ago →
    🇮🇳India ankitv18
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 215s
    #426544
  • Pipeline finished with Success
    about 2 months ago
    Total: 218s
    #426546
  • Pipeline finished with Failed
    about 2 months ago
    Total: 211s
    #426605
  • Pipeline finished with Failed
    about 2 months ago
    Total: 284s
    #426611
  • Pipeline finished with Failed
    about 2 months ago
    Total: 212s
    #426616
  • Pipeline finished with Failed
    about 2 months ago
    Total: 221s
    #426654
  • Pipeline finished with Success
    about 2 months ago
    Total: 291s
    #426663
  • Comment about 2 months ago →
    🇮🇳India ankitv18

    MR!55 is ready for a review.
    @pfrenssen please check.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024