- Issue created by @DustinYoder
- First commit to issue fork.
- Merge request !9Issue #3454768: Config to control which bundles are processed โ (Merged) created by agunjan085
- Status changed to Needs review
5 months ago 11:37am 15 June 2024 - Status changed to Needs work
5 months ago 2:52am 16 June 2024 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Thank you Gunjan this is great fast work! I think it is pretty much ready to be added as a feature! You made a code improvement with the use of instanceof, you added the help page, rolling out this feature in the way you implemented it should not change the way existing sites work, and it makes it easy to opt out for specific content typesโ very nice!
It would be ideal if it could gather all bundles across content entities (so in Drupal core, taxonomy term vocabularies and users (single bundle)). While nodes covers the 80% use case, it's always ideal to cover everything in core, and also the config schema would probably have to change if we do this later.
That said if you do not have time for that the only thing i really want to change before adding this feature is quick cosmetic things:
- The title of the settings page can simply be "Trim settings"
- The description can be "Exclude content types from Trim."
- I don't want to add another permission to anyone's Drupal site but maybe we could use one a bit more targeted than administer site configurationโ perhaps administer content types?
This is great thank you, and thank you Dustin for the suggestion!
- Assigned to agunjan085
- Status changed to Needs review
5 months ago 6:56am 18 June 2024 - ๐ฎ๐ณIndia agunjan085
Hi mlncn,
Addressed the requested changes. Please review - Issue was unassigned.
- Status changed to RTBC
5 months ago 2:47pm 18 June 2024 - ๐ฎ๐ณIndia nidhi27
Hello,
I have tested the changes from #MR9 and the functionality is working as expected.
- Status changed to Fixed
5 months ago 3:40am 22 June 2024 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Amazing agunjan085! I wish i could give you credit three times here.
Thank you for the review, Nidhi!
-
mlncn โ
committed b515ba13 on 8.x-1.x authored by
agunjan085 โ
Issue #3454768 by agunjan085, nidhi27, DustinYoder, mlncn: Config to...
-
mlncn โ
committed b515ba13 on 8.x-1.x authored by
agunjan085 โ
Automatically closed - issue fixed for 2 weeks with no activity.