Fix the issues reported by phpcs + add gitlab

Kindly review patch,,

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown.

Hi I have reviewed #2 patch and there is minor change required is

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/uswds_base/starterkits/uswds_base_subtheme/js/uswds_base.js
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

Time: 286ms; Memory: 10MB

Command use to regenerate the issue is

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/uswds_base

Fixing the remaining bug and providing patch for it.

-      $search_item = t('<li class="js-search-button-container"><button class="usa-header-search-button js-search-button">@search</button></li>'
-          , ['@search' => 'Search']);
+      $search_item = t('<li class="js-search-button-container">

Code lines are not required to be shorter than 81 characters. Line length and wrapping → , part of the Drupal coding standards, says:

• Lines containing longer function names, function/class definitions, variable declarations, etc are allowed to exceed 80 characters.
• Control structure conditions may exceed 80 characters, if they are simple to read and understand.

(Emphasis is mine.)

The existing code is simpler to read and understand than the changed code.

-1. Copy this directory to themes/custom and replace theme name in files and code with your own.
+1. Copy this directory to themes/custom and replace theme name in files and
+code with your own.

Since that text is part of a list, the last line needs to be indented.

-This sub-theme requires compiling of the USWDS CSS and also the assets folder for javascript.
+This sub-theme requires compiling of the USWDS CSS and also the assets
+folder for javascript.

Since that text is edited, the spelling of javascript should also be corrected.

+/**
+ * @file
+ * Add js code.
+ */

Add js code. does not make much sense as description, since it should describe the purpose of the code contained in that file.

Addressed #5. Updated patch. Please review.

Hi The patch #7 applies cleanly. No errors/warnings are produced anymore. The issues from #5 are also taken care. I used phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml to test.

Thanks!

- * Use init only once. The init task is meant for initializing the design system on a project.
-Since it will overwrite project files (like settings files and the Sass entry point), use it sparingly and don't use it
-for updating the design system on a project, or at any point after you've customized your settings files.
-
- * Update USWDS assets with copyAssets. Don't update assets with init, use the copyAssets task. This task updates static
-assets (like images, fonts, and compiled JavaScript) only and you don't risk clobbering your customizations.
-
- * Compile only from a single Sass entry point. Define the location of this entry point with paths.dist.theme. If you
-have project Sass files outside the paths.dist.theme directory, load these files into your single entry point via
-@forward, @use, or @import. To include these project Sass files in your gulp watch task, set paths.src.projectSass
-to your project Sass directory. The Sass will still compile from the single entry point located in paths.dist.theme.
-
- * Only check theme files and custom icons into version control. You should have a build process that copies static
-assets like images, fonts, and compiled JavaScript from the uswds package. This assures that these assets are
-up-to-date with whatever version of USWDS you're using. You only need to track your customizations
-(like settings, theme files, custom icons, and your gulpfile) in version control.
-
+ * Use init only once. The init task is meant for initializing the design
+ system on a project.
+Since it will overwrite project files (like settings files and the Sassentry
+point),use it sparingly and don't use it for updating the design system on a
+project, or at any point after you've customized your settings files.
+
+ * Update USWDS assets with copyAssets. Don't update assets with init, use
+the copyAssets task.
+This task updates static assets (like images, fonts, and compiled JavaScript)
+only and you don't risk clobbering your customizations.
+
+ * Compile only from a single Sass entry point. Define the location of this
+entry point with paths.dist.theme. If you have project Sass files outside the
+paths.dist.theme directory, load these files into your single entry point via
+@forward, @use, or @import. To include these project Sass files in your gulp
+watch task, set paths.src.
+projectSass to your project Sass directory. The Sass will still compile from the
+single entry point located in paths.dist.theme.

Since that text is part of a list, it should be formatted as the following text, similarly to the already changed text in a list.

* Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
  tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
  quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
  consequat.
* Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore
  eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt
  in culpa qui officia deserunt mollit anim id est laborum.

Addressed #10. Updated patch. Please review.

Hi everyone,

Just watching this progress.

When I reviewed at DrupalCon last week... I did notice this change.

@media (min-width: 64em) {
- .usa-header--extended .usa-navbar
- , .usa-header--extended .usa-nav__inner {
- max-width: none;
- }
+ .usa-header--extended .usa-navbar .usa-header--extended .usa-nav__inner {
+ max-width: none;
+ }
}

Please review the change... (comma)

Yes, the comma is missing in two cases.

 @media (min-width: 64em) {
-    .usa-header--extended .usa-navbar
-    , .usa-header--extended .usa-nav__inner {
-        max-width: none;
-    }
+  .usa-header--extended .usa-navbar .usa-header--extended .usa-nav__inner {
+    max-width: none;
+  }
 }

-div.usa-banner__inner
-, div.grid-container {
-    max-width: none;
+div.usa-banner__inner div.grid-container {
+  max-width: none;
 }

Ill definitely look at this closely when I’m not on my cell phone. USWDS 3.5.0 was just released, so we should be able to include these changes for uswds_base 3.4.x release. Since a new minor is out, I’d like to push out 3.4 soon.

Should be adding a gitlab file to avoid this in the future.

Started at #12 but still had about a dozen issues. Also an eslint issue. Pipeline is showing all green now.

My comment on #14 is still true

That was my mistake. Probably should of just started from scratch. These tickets have spammed the community as a whole, but adding the gitlab file will be important for the switch over.

Also with the recent changes there were some conflicts.

Fixed