- 🇮🇳India arti_parmar
I have reviewed this patch but patch is not applied cleanly.
Thanks - Status changed to Needs work
over 1 year ago 12:06pm 14 June 2023 - Issue was unassigned.
- First commit to issue fork.
- @shivam_tiwari opened merge request.
- Status changed to Needs review
over 1 year ago 12:32pm 14 June 2023 - Assigned to arpitk
- Status changed to Needs work
over 1 year ago 8:20pm 15 June 2023 - 🇮🇳India arpitk
I reviewed the MR the current changes crashed the modules. Providing the updated MR.
ArgumentCountError: Too few arguments to function Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber::__construct(), 0 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber->__construct() (line 65 of /app/web/modules/contrib/eu_cookie_compliance/src/EventSubscriber/EuCookieComplianceConfigEventsSubscriber.php)Thanks!
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:30pm 15 June 2023 - Status changed to Needs work
over 1 year ago 11:58am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
- 🇳🇴Norway svenryen
We fixed this over in 🐛 \Drupal calls should be avoided in classes, use dependency injection instead Fixed
Thanks all for the effort.
- Status changed to Closed: duplicate
about 1 year ago 12:57pm 15 October 2023