Deprecate unused MatchingRouteNotFoundException

Created a patch for Removing unused MatchingRouteNotFoundException and wrong docs, please review.
Thank You.

The last submitted patch, 4: 3350922.patch, failed testing. View results →

That was a sporadic test failure, re-test is green.

diff --git a/core/lib/Drupal/Core/Url.php b/core/lib/Drupal/Core/Url.php
index a37f75e0d1..91eb5b6698 100644
--- a/core/lib/Drupal/Core/Url.php
+++ b/core/lib/Drupal/Core/Url.php
@@ -481,9 +481,6 @@ protected static function fromRouteUri(array $uri_parts, array $options, $uri) {
    *   A Url object. Warning: the object is created even if the current user
    *   would get an access denied running the same request via the normal page
    *   flow.
-   *
-   * @throws \Drupal\Core\Routing\MatchingRouteNotFoundException
-   *   Thrown when the request cannot be matched.
    */

Let's replace this with what is really thrown, copied over from \Symfony\Component\Routing\Matcher\RequestMatcherInterface::matchRequest

    /**
     * @throws NoConfigurationException  If no routing configuration could be found
     * @throws ResourceNotFoundException If no matching resource could be found
     * @throws MethodNotAllowedException If a matching resource was found but the request method is not allowed
     */

NW for that, otherwise RTBC.

added updated patch and address #7

Part of me is saying this should be deprecated vs just removing but searching

https://git.drupalcode.org/search?group_id=2&scope=blobs&search=Matching...

I couldn't find any usage other then core forks.

 // cspell:ignore abempty
-
 /**

Out of scope change added in #8 that should be fixed if committed. But won't hold for that 1 space.

The last submitted patch, 4: 3350922.patch, failed testing. View results →

(Yers, 4 is red, but 8 is green...)

Yes, I agree we need to deprecate the class before we can remove it - see the policy for how we deprecate concrete classes → .

Update the MR, created a CR.

Looks good, nothing more to add.

Committed/pushed to 11.x, thanks!

catch → closed merge request !8852

Automatically closed - issue fixed for 2 weeks with no activity.