Refactor Claro's modules-page stylesheet

Gauravvv → made their first commit to this issue’s fork.

Only changed color variables, So I don't think we need screenshots.

Changes look like.

But since the .css file changed can we get before/after screenshots please.

After patch

Thanks

The last submitted patch, 5: 3332425-5.patch, failed testing. View results →

Re-storing status, unrelated failure.

The last submitted patch, 5: 3332425-5.patch, failed testing. View results →

Random failure

The last submitted patch, 5: 3332425-5.patch, failed testing. View results →

@Gauravvvv we could have created variables for the borders as well.

Created a new patch. Added border-variables. Please review it.

Guys, can you please explain why I am getting this CCF my patch is passed, and after clicking on CCF I am not able to see the exact error which I can resolve, please help me to understand this so that I can verify the same and it will be helpful for me in the future, Really appreciated if you would help me in this.

Thanks

Random failure in #5

@Akshay kashyap not sure we need a variable for 0. Could be wrong but don't see anywhere else in the theme we use variables for 0.

The last submitted patch, 5: 3332425-5.patch, failed testing. View results →

Possible a dependency update changed the compiled css => CCF, let's reroll this one. feeling lucky, adding the tag :)

added updated patch to fix CCF #16

+++ b/core/themes/claro/css/components/modules-page.css
@@ -57,3 +57,3 @@
+  border: var(-modules-page-system-modules-extrasmall-border-size);

missing a - here.

Fix for mention in #23
thanks

It looks like we can improve the nesting

.system-modules, .locale-translation-status-form {
  & tr.even, & tr.odd {
    border: black;
  }
}

and so on.

Reposted patch #5. removed unnecessary patches. please review

Patch was RTBC in #9, since we have a RTBC and screenshot for that one I'd rather commit this and address the border in a followup if needed.

Using vars for border is a good idea too. It's just that I'd rather commit this one than wait a few days/weeks for the additional scope to be done.

Committed cc5e347 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.