Fix the issues reported by phpcs

checked MR still there are one issue

FILE: ...ktop/Contribution/drupal9.5.x/drupal/modules/contrib/token_views_filter/src/TokensFilterTrait.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
139 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

added updated patch and Fixed remaining issue

hello Team,

I will review the patch #5.

Hello Team,

Patch #5 gets applied and fixes all the issues reported by PHPCS.
so #5 is ready to move to RTBC. i.e. RTBC +1.

-        // Value can be optional, For example for 'empty' and 'not empty' filters.
+        // Value can be optional, For example 'empty' and 'not empty' filters.

After a comma, for is not spelled in capital case.

+/**
+ * @file
+ * Contains the Hook implementations.
+ */

Hook does not need to be in capital case, since it is not at the beginning of a sentence.

That comment is usually Hook implementations for [module name].

Hello @apaderno

Will work on the #5 patch and make changes as per your suggection and provide the new patch.

Fixed remaining issues reported with PHPCS.
Kindly review.

-views.filter.string:
+views . filter . string:

That line is correct as it is.

-   * In case of grouped filters we have to override the parent FilterPluginBase 
+   * In case of grouped filters we have to override the parent FilterPluginBase
    * method so that we can tokenize the individual group_item's value.

It is not necessary to say which is the parent class; parent method is sufficient.

+ * @file
+ * Contains the hook implementation for token view filter test.

The usual comment is Hook implementations for [module name].

- * Primarily Drupal hooks to manipulate Token Views Filter.
+ * Primarily Drupal hooks to manipulate token views filter.

Primarily is an adverb; it cannot be used to alter a noun phrase (Drupal hooks).
Drupal does not make any distinction between primary and secondary hooks. The usual comment is another one.

-views.filter.string:
+views . filter . string:

It has been already pointed out that change is wrong.

-        // Value can be optional, For example for 'empty' and 'not empty' filters.
+        // Value can be optional, For example 'empty' and 'not empty' filters.

A word after a comma does not need to be written in capital case, except in the case that word is always written in capital case.

+/**
+ * @file
+ * Hook implementations for [module name].
+ */
+

This module name is not [module name]. Clearly, in my previous comment, I used a placeholder since, speaking for every module, I cannot list the names of every module.

+/**
+ * @file
+ * Hook implementations for tokens in views filter criteria.
+ */

The module name should also respect uppercase letters.

/**
  * @file
- * Primarily Drupal hooks to manipulate Token Views Filter.
+ * Primarily Drupal hooks to manipulate token views filter.
  */

That comment is not correct for the reasons I have already reported. It does not describe the purpose of the functions contained in the token_views_filter.views.inc file, then.

I have fixed the issue please review.

I updated commit, Please review now.

 /**
  * @file
- * Primarily Drupal hooks to manipulate Token Views Filter.
+ * Hooks to modify views filter handler plugin.
  */

A .views.inc file contains hook implementations used by the Views module. The correct description is Hook implementations used by the Views module. or Hook implementations used by Views. invoked is a fine replacement for used.

As per comment #22, I updated the Description of the hook implementation.

Updated all the code as per the comments. Please check.

 To use token views filter you should redefine original views filter schema 
-in your module in file `config/schema/{module_name}.schema.yml`
+in your module in file `config / schema / {module_name} . schema . yml`

Spaces in file paths are not used. It is already correct as it is.

Thanks for all!!!!
Changes has been merged to dev branch.

Automatically closed - issue fixed for 2 weeks with no activity.