- Issue created by @yasminOrj
- Merge request !21Issue #2796537 by scott_euser, dpi, Algeron, JensH, JeroenT: Saved menu is... → (Open) created by arunsahijpal
- 🇮🇳India arunsahijpal
Hi @yasminorj ,
I've fixed the phpcs errors and the phpcs is also passing the pipeline, kindly check. - 🇵🇭Philippines roberttabigue
Hi @arunsahijpal,
After reviewing and applying the MR!21 to the Menu Admin per Menu module with 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See below:FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/menu_admin_per_menu/README.md -------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 11 | WARNING | Line exceeds 80 characters; contains 192 characters -------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/menu_admin_per_menu/src/Access/MenuAdminPerMenuAccess.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_admin_per_menuI'm moving this to ‘Needs work’ for now.
Thank you!
- 🇮🇳India arunsahijpal
Hi @roberttabigue,
Fixed the remaining phpcs errors, kindly check. - 🇵🇭Philippines roberttabigue
Hi @arunsahijpal,
I have applied the latest MR !21 to the Menu Admin per Menu module with 8.x-1.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_admin_per_menuPlease see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!