Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 13 June 2022, over 2 years ago
Updated 21 August 2024, 3 months ago
📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India Rakhi Soni

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Merge request !1Issue #3285448: Fix: phpcs --standard=Drupal issues. → (Open) created by batigolix
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Issue was unassigned.
  • Comment 10 months ago →
    🇷🇺Russia zniki.ru
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇵🇭Philippines roberttabigue

    Hi @batigolix,

    After reviewing and applied the MR!1 to the FortyTwo - Administration theme against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
    See below:

    FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/includes/bootstrap.inc
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/css/fortytwo_admin.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/plugins/window-size.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/transit.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/enquire.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/polyfills/placeholder.js
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 59 | ERROR | [x] Opening brace must be the last content on the line
 71 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

    I ran this command on the theme:
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js fortytwo_admin/

    I'm moving this to ‘Needs work’ for now.

    Thank you!

  • Merge request !2Created a new merge request to get a list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
  • Pipeline finished with Success
    4 months ago
    Total: 189s
    #239657
  • Pipeline finished with Success
    4 months ago
    Total: 184s
    #239665
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno → changed the visibility of the branch 3285448-gitlab-ci-reports to hidden.

  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Canceled
    4 months ago
    Total: 74s
    #239668
  • Pipeline finished with Success
    4 months ago
    Total: 183s
    #239669
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇵🇭Philippines roberttabigue

    Hi @avpaderno,

    After reviewing and applying your latest commits to MR!1 for the FortyTwo - Administration theme against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
    See below:

    FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/css/fortytwo_admin.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/plugins/window-size.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/transit.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/enquire.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/polyfills/placeholder.js
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 59 | ERROR | [x] Opening brace must be the last content on the line
 71 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

    I ran this command on the theme:
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js fortytwo_admin/

    I'm moving this to ‘Needs work’ again.

    Thank you!

  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    Also, File appears to be minified and cannot be processed is not a warning for something that needs to be changed. It is just a warning about PHP_CodeSniffer that is not able to handle minified files.

  • Status changed to RTBC 3 months ago
  • Comment 3 months ago →
    🇵🇭Philippines roberttabigue

    Hi @avpaderno,

    Confirmed PHPCS errors no longer exist: https://git.drupalcode.org/issue/fortytwo_admin-3285448/-/jobs/2505378.

    Please see the attached file for reference.

    I'm moving this now to ‘RTBC’.

    Thank you!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024