- 🇮🇳India Prem Suthar gujrat
I have Fixed The Phpcs error of #6
remain part is warnings.
FILE: /home/prem/Documents/drupal11/modules/custom/social_media_links/src/IconsetFinderService.php -------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------- FILE: ...em/Documents/drupal11/modules/custom/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldFormatter/SocialMediaLinksFieldDefaultFormatter.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 216 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 229 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- Status changed to Needs review
4 months ago 5:59am 20 February 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
It is probably better to first commit 📌 Add support for GitLab CI Needs review which would also enable running PHP_CodeSniffer when a merge request is created, or a commit done.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3315142-coding-standards-issue to hidden.
- Merge request !39Issue#3314142: Fixing phpcs issues reported in the gitlab. → (Open) created by ankitv18
- Issue was unassigned.
- 🇮🇳India ankitv18
Please review MR!39 ~~ All the phpcs errors reported in the gitlab CI are fixed now, phpstan issue is done in https://www.drupal.org/project/social_media_links/issues/3413678 📌 Drupal calls should be avoided in classes, use dependency injection instead Needs review