PHPcs fixes reported the Gitlab CI job

Issue summary updated

I have Fixed The Phpcs error of #6

remain part is warnings.

FILE: /home/prem/Documents/drupal11/modules/custom/social_media_links/src/IconsetFinderService.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------


FILE: ...em/Documents/drupal11/modules/custom/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldFormatter/SocialMediaLinksFieldDefaultFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 216 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 229 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------

It is probably better to first commit 📌 Add support for GitLab CI Needs review which would also enable running PHP_CodeSniffer when a merge request is created, or a commit done.

ankitv18 → closed merge request !21

ankitv18 → changed the visibility of the branch 3315142-coding-standards-issue to hidden.

Please review MR!39 ~~ All the phpcs errors reported in the gitlab CI are fixed now, phpstan issue is done in https://www.drupal.org/project/social_media_links/issues/3413678 📌 Drupal calls should be avoided in classes, use dependency injection instead Needs review

Hi @ankitv18,

I am moving this to 'Needs work', please check the PHPCS issues below after applying the 'MR !39' to the Social Media Links Block and Field module against 8.x-2.x-dev on my D10 local.
See below:

FILE: ...roject/DrupalOrg/drupalorgissues/web/modules/contrib/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldWidget/SocialMediaLinksFieldBaseWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: ...upalOrg/drupalorgissues/web/modules/contrib/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldFormatter/SocialMediaLinksFieldDefaultFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 218 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 231 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/social_media_links/src/IconsetFinderService.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
 72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig social_media_links

I'm moving this to ‘Needs work’ for now.

Thank you!

Thanks @roberttabigue for the review
Please check the gitlab pipeline:https://git.drupalcode.org/issue/social_media_links-3315142/-/pipelines/...

Direct drupal calls issues will be fixed as a part of phpstan pipeline.

Hi @ankitv18,

Thank you for responding! I saw that all the PHPCS issues have been resolved here: https://git.drupalcode.org/issue/social_media_links-3315142/-/pipelines/....

I'm moving this now to 'RTBC'.

Thank you!

Closing since I've already ran the automated phpcs linting process which makes this issue redundant.