Vulcan Coding Standard Issue

Hi @Deepthi kumari,
After applying your Patch #3 to the Start Trek module on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/startrek.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessage.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManager.
 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 43 | ERROR   | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 44 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 45 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 45 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
 45 | ERROR   | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/Controller/KobayashiMaruController.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserInterface.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessageInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserYAML.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Exception\InvalidDataTypeException.
 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EventSubscriber/CrewSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  8 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Authentication\AuthenticationManager.
 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 43 | ERROR   | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 44 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 45 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 45 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
 45 | ERROR   | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 101ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml startrek
I'm moving this to ‘Needs work’ for now.
Thank you!
Vulcan Coding Standard Issue

Comments & Activities
