Fix issues reported by PHPCS

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trusted_redirect/ FILE: /var/www/web/modules/contrib/trusted_redirect/modules/trusted_redirect_entity_edit/trusted_redirect_entity_edit.info.yml ------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/web/modules/contrib/trusted_redirect/modules/trusted_redirect_entity_edit/src/Service/EntityEditUrlResolver.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------ 156 | ERROR | [ ] Description for the @return value is missing 178 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: ...ww/web/modules/contrib/trusted_redirect/modules/trusted_redirect_entity_edit/src/EventSubscriber/TrustedRedirectEntityEditSubscriber.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/trusted_redirect/src/EventSubscriber/TrustedRedirectSubscriber.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Component\HttpFoundation\SecuredRedirectResponse. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/trusted_redirect/trusted_redirect.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- Time: 368ms; Memory: 10MB

Comments & Activities

Issue created by @abhiyanshu
Comment about 2 months ago →
nidhish
Comment about 2 months ago →
nidhish
@abhiyanshu, The date stamp, version, project warning is coming because of installing dependencies through composer in your local system. It would not appear in the codebase. I am fixing phpcs issues and pushing it to the codebase.
Merge request !9Fixed PHPCS issues/errors → (Open) created by Unnamed author
Comment about 2 months ago →
nidhish
Comment about 2 months ago →
🇮🇳India abhiyanshu
@nidhish, You can ignore the info file.
Comment about 2 months ago →
🇮🇳India abhiyanshu
Comment about 2 months ago →
nidhish
Comment about 2 months ago →
🇵🇭Philippines roberttabigue
Hi @nidhish,

I have applied the latest MR !9 to the Trusted redirect module with 8.x-1.13 on Drupal 10 and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trusted_redirect

Please see the attached files for reference.

I'm moving this now to ‘RTBC’.

Thank you!
Comment about 1 month ago →
nidhish
@roberttabigue Kindly close the merge request and provide issue credit.
Comment about 1 month ago →
nidhish

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9Fix issues reported by PHPCS
Open

Comments & Activities

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9Fix issues reported by PHPCSOpen

Comments & Activities

!9Fix issues reported by PHPCS
Open