- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:17am 22 June 2023 - last update
over 1 year ago 2 pass - First commit to issue fork.
- 🇮🇳India dineshkumarbollu
Hi
The patch applied cleanly and fixed all the phpcs errors.Thanks
- @dineshkumarbollu opened merge request.
- Status changed to RTBC
over 1 year ago 7:13am 22 June 2023 - Status changed to Needs work
over 1 year ago 8:53am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
/** * @file + * Implements csv_serialization module. */
The usual description is Hook implementations for the [module name] module. where [module name] is the module name shown in the .info.yml file.
Furthermore, the report shows errors/warnings for five files, but the patch changes only two files.
- Assigned to nitin_lama
- Issue was unassigned.
- 🇮🇳India nitin_lama India
Addressing #8. Errors/warnings still needs to be addressed.
- Assigned to arti_parmar
- Status changed to Needs review
over 1 year ago 9:39am 22 June 2023 - last update
over 1 year ago 2 pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:47pm 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The report shows that five files should be changed. The last patch changes only two files.
- Status changed to Needs review
over 1 year ago 12:49pm 27 July 2023 - 🇮🇳India chaitanyadessai Goa
Patch #10 applied cleanly.
After executing below command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml csv_serialization/, only two files are listing errors which are fixed in #10 patch. - Status changed to RTBC
over 1 year ago 4:40pm 28 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi,
I reviewed the changes and confirmed the Patch #10 was applied cleanly to the CSV Serialization module against 3.x-dev on Drupal 9.5.10.
Checking patch README.md... Checking patch csv_serialization.install... Applied patch README.md cleanly. Applied patch csv_serialization.install cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml csv_serialization/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
- Status changed to Needs work
over 1 year ago 7:11am 30 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
See my previous comment: The report shows that five files should be changed; the last patch changes only two files.
- Status changed to Needs review
over 1 year ago 3:01pm 30 July 2023 - 🇮🇳India bharath-kondeti Hyderabad
@apaderno
From the issue summary, we have 3 files with end on line issues "End of line character is invalid; expected "\n" but found "\r\n""
Git ignores this while pushing the changes. I think that is the reason 3 files are missing from the patch.. - Status changed to RTBC
over 1 year ago 4:32pm 31 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi @apaderno,
Moving this again to RTBC, please check the feedback of @bharath-kondeti.
Thank you!
- Status changed to Needs work
over 1 year ago 11:06pm 31 July 2023 - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 11:01pm 16 November 2023 - Status changed to Closed: outdated
12 months ago 2:17pm 5 December 2023