Fixed Drupal Coding Standards and compatibility with Drupal 9

Hi @vipin.mittal18,

I have reviewed the changes and confirmed that Patch #2 was applied cleanly to the Data-hover Filter module against 8.x-1.1 on Drupal 10, and all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js data_hover_filter/

Please see the attached file for reference.

I'm moving this now to ‘RTBC’.

Thank you!

Let's create a merge request, now that patches are no longer tested.

Hi @avpaderno,

After reviewing and applied the MR!1, I still see 1 PHPCS warning.
See below:

FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/data_hover_filter/data_hover_filter.info.yml
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------------------

I'm moving this to ‘Needs work’ for now.

Thank you!

The content of the data_hover_filter.info.yml file is the following.

name: Data hover Filter
description: Custom text filter to add a data-hover attribute to links.
type: module
package: custom
core: 8.x
core_version_requirement: ^8 || ^9

Hi @avpaderno,

Confirmed all PHPCS errors have been fixed already.

Please see the attached file for reference.

I'm moving this now to ‘RTBC’.

Thank you!