- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:34am 23 February 2023 - Status changed to RTBC
over 1 year ago 6:29am 23 February 2023 - ๐ฎ๐ณIndia rassoni Bangalore
Rashmisoni โ made their first commit to this issueโs fork.
- Status changed to Needs work
over 1 year ago 9:35am 24 February 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * The TYPE_PREFIX constant. + */ private const TYPE_PREFIX = 'admin:';
Instead of repeating what the code already says, that documentation comment should say the purpose of that constant.
- Status changed to Needs review
over 1 year ago 9:48am 27 February 2023 - ๐ณ๐ฑNetherlands bbrala Netherlands
Thank you. But will not be merging this, we do not use comments in this way. I'll put in gitlab and phpcs in a d11 issue.
- Status changed to RTBC
4 months ago 6:24pm 12 July 2024 - ๐ต๐ญPhilippines roberttabigue
Hi @everyone!
I have applied the latest fixes to the Admin Toolbar Messages module against 1.0.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml admin_toolbar_messages/
Please see the attached file for reference.
I'm moving this now to โRTBCโ.
Thank you!
- Status changed to Needs work
4 months ago 9:12am 13 July 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
PHP_CodeSniffer could report no errors/warnings, but the changes done are not correct.
- Status changed to Closed: won't fix
4 months ago 9:28am 13 July 2024 - ๐ณ๐ฑNetherlands bbrala Netherlands
This issue will not be fixed. If you want to help out check out this issue: https://www.drupal.org/project/admin_toolbar_messages/issues/3460980 ๐ Drupal 11 compatiblity and gitlab Needs review