Coding Standard issues

Created on 28 April 2017, over 7 years ago
Updated 28 May 2024, 6 months ago

There are coding standard issues.

πŸ› Bug report
Status

Needs work

Version

1.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States cmsMinds

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work 6 months ago
  • πŸ‡΅πŸ‡­Philippines roberttabigue

    Hi @Deepthi kumari,

    After applying your Patch #3 to the Ckeditor Shortcode module against 8.x-1.1 on Drupal 10, not all of the PHPCS errors were resolved.
    Please see below:

    FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/ckeditor_shortcodes.info.yml
    ---------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
     1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
     1 | WARNING | "core_version_requirement" property is missing in the info.yml file
     7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
    ---------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/src/Plugin/CKEditorPlugin/btshortcodes.php
    -----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------------
      6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ckeditor\CKEditorPluginBase.
     17 | ERROR | [ ] Class name doesn't match filename; expected "class btshortcodes"
    -----------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 77ms; Memory: 10MB

    I'm moving this to 'Needs work' for now.

    Thank you!

Production build 0.71.5 2024