Contrib.social

Fix what reported by phpcs

Open on Drupal.org →
Created on 29 October 2022, almost 2 years ago
Updated 19 July 2024, about 2 months ago

GitLab CI reports the following PHP_CodeSniffer warnings/errors, which should be fixed.

FILE: ...odules/custom/syncer-3318116/tests/src/FunctionalJavascript/SyncerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\FunctionalJavascriptTests\WebDriverTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...issue/syncer-3318116/web/modules/custom/syncer-3318116/src/BatchExport.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be
   |       |     referenced with use statements
   |       |     (Drupal.Classes.UseGlobalClass.RedundantUseStatement)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...issue/syncer-3318116/web/modules/custom/syncer-3318116/src/Form/Import.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\syncer\BatchImport.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 9 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be
   |       |     referenced with use statements
   |       |     (Drupal.Classes.UseGlobalClass.RedundantUseStatement)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...sue/syncer-3318116/web/modules/custom/syncer-3318116/src/Form/BaseForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...syncer-3318116/web/modules/custom/syncer-3318116/src/Controller/Export.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
--------------------------------------------------------------------------------
Time: 218ms; Memory: 6MB

 
 

📌 Task
Status

RTBC

Version

2.0

Component

Code

Created by

🇮🇳India Rohit Rana

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 3 months ago →
    🇮🇳India dev16.addweb

    Patch with some other phpcs fixes.Please review.

    FILE: syncer/tests/src/FunctionalJavascript/SyncerTest.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\FunctionalJavascriptTests\WebDriverTestBase.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: syncer/src/Form/Import.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\syncer\BatchImport.
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: syncer/src/Form/BaseForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
  • Merge request !2Issue #3318116: Fix what reported by phpcs → (Open) created by apaderno
  • Pipeline finished with Failed
    3 months ago
    Total: 172s
    #186211
  • Merge request !3Issue #3318116: Fix what reported by phpcs → (Open) created by apaderno
  • Pipeline finished with Failed
    3 months ago
    Total: 170s
    #186228
  • Comment 3 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    apaderno → changed the visibility of the branch 3318116-fix-phpcs-issues to hidden.

  • Comment 3 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Failed
    3 months ago
    Total: 179s
    #186845
  • Status changed to Needs work about 2 months ago
  • Comment about 2 months ago →
    🇵🇭Philippines roberttabigue

    Hi @apaderno,

    After applying the MR!3 to the Content syncer module against 8.x-2.x-dev on Drupal 10, I still see 1 PHPCS warning.
    See below:

    FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/syncer/src/Controller/Export.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

    I ran this command on the module:
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig syncer

    I'm moving this to ‘Needs work’ for now.

    Thank you!

  • Status changed to Needs review about 2 months ago
  • Comment about 2 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Failed
    about 2 months ago
    Total: 129s
    #228119
  • Status changed to RTBC about 2 months ago
  • Comment about 2 months ago →
    🇵🇭Philippines roberttabigue

    Hi @avpaderno,

    I have applied the latest MR!3 again to the Content syncer module against 8.x-2.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.

    Please see the attached file for reference.

    I'm moving this now to ‘RTBC’.

    Thank you!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024