- ๐ฎ๐ณIndia dev16.addweb
Patch with some other phpcs fixes.Please review.
FILE: syncer/tests/src/FunctionalJavascript/SyncerTest.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\FunctionalJavascriptTests\WebDriverTestBase. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: syncer/src/Form/Import.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\syncer\BatchImport. ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: syncer/src/Form/BaseForm.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3318116-fix-phpcs-issues to hidden.
- Status changed to Needs work
about 2 months ago 4:55pm 18 July 2024 - ๐ต๐ญPhilippines roberttabigue
Hi @apaderno,
After applying the MR!3 to the Content syncer module against 8.x-2.x-dev on Drupal 10, I still see 1 PHPCS warning.
See below:FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/syncer/src/Controller/Export.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name -----------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig syncer
I'm moving this to โNeeds workโ for now.
Thank you!
- Status changed to Needs review
about 2 months ago 5:26pm 18 July 2024 - Status changed to RTBC
about 2 months ago 4:32pm 19 July 2024 - ๐ต๐ญPhilippines roberttabigue
Hi @avpaderno,
I have applied the latest MR!3 again to the Content syncer module against 8.x-2.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
Please see the attached file for reference.
I'm moving this now to โRTBCโ.
Thank you!