hook_critical_css_file_paths_suggestion_alter type hint is wrong

Open on Drupal.org →

Created on 13 June 2024, 5 months ago

Problem/Motivation

The $entity argument of the hook_critical_css_file_paths_suggestion_alter() function has ContentEntityInterface as typehint. However, in practice, NULL can also be passed as argument.

Proposed resolution

Expand the typehint.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!9hook_critical_css_file_paths_suggestion_alter type hint is wrong
Merged
🇧🇪Belgium dieterholvoet
updated 25 days ago

Comments & Activities

Issue created by @dieterholvoet
Merge request !9Expand the typehint → (Merged) created by dieterholvoet
Status changed to Needs review 5 months ago9:23am 13 June 2024
Comment 5 months ago →
🇧🇪Belgium dieterholvoet Brussels
Status changed to RTBC 5 months ago9:00pm 20 June 2024
Comment 5 months ago →
🇨🇦Canada czunigaco
I was having this issue:

"TypeError: my_module_critical_css_file_paths_suggestion_alter(): Argument #2 ($entity) must be of type Drupal\Core\Entity\ContentEntityInterface, null given"

Applying MR 9, and it fixed it for me.
Comment 25 days ago →
🇪🇸Spain albertosilva Basque Country
Merged, thanks
Comment 25 days ago →
🇪🇸Spain albertosilva Basque Country
Comment 25 days ago →
🇪🇸Spain albertosilva Basque Country

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024