hook_critical_css_file_paths_suggestion_alter type hint is wrong

Created on 13 June 2024, 15 days ago

Updated 20 June 2024, 7 days ago

Problem/Motivation

The $entity argument of the hook_critical_css_file_paths_suggestion_alter() function has ContentEntityInterface as typehint. However, in practice, NULL can also be passed as argument.

Proposed resolution

Expand the typehint.

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇧🇪Belgium DieterHolvoet Brussels

Live updates comments and jobs are added and updated live.

Merge Requests

!9hook_critical_css_file_paths_suggestion_alter type hint is wrong
Open
🇧🇪Belgium DieterHolvoet
updated 15 days ago

Comments & Activities

Issue created by @DieterHolvoet
Merge request !9Expand the typehint → (Open) created by DieterHolvoet
Status changed to Needs review 15 days ago9:23am 13 June 2024
Comment 15 days ago →
🇧🇪Belgium DieterHolvoet Brussels
Status changed to RTBC 7 days ago9:00pm 20 June 2024
Comment 7 days ago →
🇨🇦Canada czunigaco
I was having this issue:

"TypeError: my_module_critical_css_file_paths_suggestion_alter(): Argument #2 ($entity) must be of type Drupal\Core\Entity\ContentEntityInterface, null given"

Applying MR 9, and it fixed it for me.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024

hook_critical_css_file_paths_suggestion_alter type hint is wrong

Problem/Motivation

Proposed resolution

Merge Requests

!9hook_critical_css_file_paths_suggestion_alter type hint is wrongOpen

Comments & Activities

!9hook_critical_css_file_paths_suggestion_alter type hint is wrong
Open