Making other assets asynchronous fails in AJAX requests since Drupal 10.1.0

Created on 22 September 2023, 9 months ago

Updated 29 December 2023, 6 months ago

Problem/Motivation

In addition to not being able to add inline CSS to AJAX requests, there's another issue caused by 📌 Improve Drupal\Core\Ajax\AddCssCommand to accept an array of CSS assets Fixed . In CssCollectionRenderer::makeAssetsAsync, we duplicate the asset and add some attributes for print media.

The problem is that the uniqueBundleId in Drupal.AjaxCommands.prototype.add_css() is not unique enough: it joins style.href and ajax.instanceIndex, but both of those are the same in case of the print media duplicates we make. This causes an error in loadjs (relevant line), the JS library which is used for loading the JS/CSS files, because it thinks we're adding the same asset twice.

Steps to reproduce

Try to trigger any AJAX request: can be e.g. a Webform submit.

Proposed resolution

I'm not sure this can be fixed in the Critical CSS module, this might be something that needs to be fixed in Drupal core. Drupal.AjaxCommands.prototype.add_css() will need to include a hash of all attributes in the unique bundle ID.

Remaining tasks

Check if we can find a temporary workaround for this module.
Create a core issue.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium DieterHolvoet Brussels

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @DieterHolvoet
Comment 9 months ago →
🇧🇪Belgium DieterHolvoet Brussels
Status changed to Needs work 9 months ago2:26pm 22 September 2023
Comment 9 months ago →
🇧🇪Belgium DieterHolvoet Brussels
Using the patch from 🐛 Not all attributes are used when considering an asset as unique Needs review fixes the issue, but we should look into a workaround that doesn't involve applying patches.
Assigned to albertosilva
Status changed to Active 6 months ago8:53am 29 December 2023
Comment 6 months ago →
🇪🇸Spain albertosilva Basque Country
Hi,

Could you please confirm if the solution provided by https://www.drupal.org/project/critical_css/issues/3394895 🐛 Critical CSS breaks AJAX Dialogs (popups) in D10 Active is working for you? I have already committed the patch from that issue, and I think it should also work for you use case.

Thanks

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024