Not all attributes are used when considering an asset as unique

Created on 22 September 2023, about 1 year ago

Updated 6 October 2023, about 1 year ago

Problem/Motivation

The uniqueBundleId in Drupal.AjaxCommands.prototype.add_css() is not unique enough: it joins style.href and ajax.instanceIndex, but that's not enough if two assets share the same path but have different attributes. An example of where this is done is the Critical CSS module 🐛 Making other assets asynchronous fails in AJAX requests since Drupal 10.1.0 Active . This causes an error in loadjs (relevant line), the JS library which is used for loading the JS/CSS files, because it thinks we're adding the same asset twice.

Steps to reproduce

Enable and configure the Critical CSS module → .
Try to trigger any AJAX request: can be e.g. a Webform submit.

Proposed resolution

Drupal.AjaxCommands.prototype.add_css() needs to include a hash of all attributes in the unique bundle ID.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Ajax →

Last updated about 15 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Comments & Activities

Issue created by @dieterholvoet
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
Not currently mergeable.
@dieterholvoet opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,168 pass
Status changed to Needs review about 1 year ago2:24pm 22 September 2023
Comment about 1 year ago →
🇧🇪Belgium dieterholvoet Brussels
Test failure seems unrelated.
Status changed to Needs work about 1 year ago2:24pm 25 September 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Thanks for reporting.

Could we get a test case showing the issue?
Comment about 1 year ago →
🇧🇪Belgium dieterholvoet Brussels
The same seems to apply to JS libraries, but maybe that should be a separate issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024