Settings form error on D11

Created on 29 October 2024, 26 days ago

Problem/Motivation

On D11 (PHP8.3), the module's settings form throws this error:

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/critical_css/src/Form/SettingsForm.php on line 36 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

Steps to reproduce

Install this module on D11 and go to /admin/config/development/performance/critical-css.

Proposed resolution

Update SettingsForm::__construct() and SettingsForm::create() as required.

I already have a fix, so will create a fork & MR.

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kentr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024