- Issue created by @edmund.dunn
- 🇦🇺Australia thomwilhelm Sydney
Having the same issue after going from 4.0.18 to 4.0.19 whilst on Drupal 10.2, seems like the change in this issue caused the regression for me:
https://www.drupal.org/project/environment_indicator/issues/3456599 🐛 Toolbar active tab background is always white on Drupal 10.3 Fixed
- Status changed to RTBC
9 months ago 2:20pm 26 July 2024 - 🇺🇸United States loopy1492
Onlu the active button was really affected for us. I applied the patch from #2 and it fixed the problem for us:
core: 10.3.1
environment_indicator: 4.0.19 - First commit to issue fork.
- Merge request !71Close #3463388 Ensure foreground color is honored. → (Merged) created by trackleft2
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Setting priority to major since this is one of the key settings in this module.
- First commit to issue fork.
-
isholgueras →
committed 1d5b9862 on 4.x authored by
trackleft2 →
Issue #3463388: Foreground color setting broken for toolbar integration
-
isholgueras →
committed 1d5b9862 on 4.x authored by
trackleft2 →
- Status changed to Fixed
3 months ago 11:52am 15 January 2025 - 🇷🇴Romania dragos-dumi
After this change, the workspace indicator colors in the toolbar gets overwritten with the bg and fg color and might confuse users as you get for example green color on any Workspace. Attached a patch for this, if someone is lookig for a quick fix.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
@dragos-dumi Interesting, thanks for the report. I'll make an issue for this module to create an automated test for how this module interacts with workspaces module.
$('.toolbar .toolbar-bar .toolbar-tab > .toolbar-item').css('background-color', settings.environmentIndicator.bgColor);This new code now changes the background color of our custom toolbar elements. Now sure what to do with that 🤔
Also, the jQuery code does not use the context for the element selection. So every time it is applied to the whole page, no matter of the passed context.