Resolve access check errors for D10 compatibility

Patch #2 worked for me for the Drupal 10 upgrade,

Thanks!

Greetings!

I tested this on my local installation for a Drupal 9 site. The patch applied successfully and I have thus updated the status from Needs review to Reviewed & tested by the community.

The patch #2 is working.
Thank you, lelkneralfaro!

Hi @all Tested the patch. The patch LGTM.

kunal@LAPTOP-G4FTKS5H MINGW64 /c/xampp/htdocs/contributions/web/modules/contrib/admin_toolbar-3338408 (3338408-resolve-access-check)
$ git apply -v admin_toolbar-resolve_access_check-3338408-2.patch
Checking patch admin_toolbar_search/src/SearchLinks.php...
Checking patch admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php...
Applied patch admin_toolbar_search/src/SearchLinks.php cleanly.
Applied patch admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php cleanly.

RTBC++ #2.

Creating a MR for helping the maintainer.

please review and merge this MR.

Thanks

it's pretty much a false positive, those are *very likely* config entities (never seen a content bundle entity, doesn't make sense), it won't do anything but if we do something it should be an accessCheck(FALSE) just in case core ever actually adds access checks/query altering to config entity queries.

Either way, you can safely ignore this and do not need to apply it as a patch to your site.

#11 would not apply. I rerolled it for the latest release(3.4.1).

The last submitted patch, 14: 3338408-fix-access-check-error.patch, failed testing. View results →

Checked patch from #14 (and re-run automated tests for D10.1, D9.5 with php 8.1/Mysql 8 - passed).
Works for me.

@PrabuEla
I hide your patch because you changed accessCheck(FALSE) to accessCheck(TRUE) - which was already discussed in #10 and implemented in #14.

I hid patch from #2 too.

Please make new release with this patch, so we can update sites to D10.

You don't need this patch, the module works perfectly well on D10 without it. See #10.

I fixed access check errors for D10 compatibility. attached patch.
Thanks

Update patch to consider the sort() added in between on these lines.
Using the module base path.

I fixed access check errors for D10 compatibility

@yuvania
This is the same patch as in #14.
See also remarks in #10 and #23.

The patch in comment #14 📌 Resolve access check errors for D10 compatibility Needs review has worked for drupal 10.1

Agree: tested patch #14 [3338408-fix-access-check-error.patch] applies as expected.

Prashant.c → made their first commit to this issue’s fork.

Re-based with 3.x, needs to be reviewed.
Thanks

Added a comment in the MR. If someone review and update?
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/51