@eelkeblok I think that before merging we need to rewrite and clean up forum_access to be a bit more OOP. This was converted from D7 to D8 and has a lot part of functional code.
I've made all planned fixes and now pipeline for MR10 is green. Also I think we should make 2.0.x version since minimal required Drupal version was bumped to 10.3+.
We need to fix phpstan and phpcs errors. I already fixed some problems for D11 compatibility in MR10.
@gisle you can provide QA for 2.0.x branch. I added Gitlab CI for this branch a time ago.
@avpaderno Yes, I'm interested to have all permissions for this project.
@bluegeek9 can you release new version of smtp with this fix.
I’m encountering this error in Drupal 11 in my custom modules for custom entities. But error message did't say where error was.
@sirclickalot, you can propose MR to add this features to ODT Importer.
@johnwt I can't reproduce this error on my clients D11 sites. I'm ready to review patches and MR's.
@eelkeblok I reviewed your MR, but it contains commits that was fixed in 2.0.x branch time ago. Can you create fresh MR for 2.0.x with template fixes?
I can't reproduce this issue. My clients use D10 for now. But we plan to upgrade. I will see once they moved on D11.2+.
@eelkeblok did you compare forum-access-table.html.twig from #10 with current version from 2.0.x git?
#76 Fixed my issues in custom entity edit form.
As @int_ua mentioned above code runs twice. In first run we have correct #action and on the second run we have taxonomy/term/all.
I tried code from patch #23 in D11 and $this->view->display_handler->getPath() returns taxonomy/term/%term. So we need to fix that.
Need reroll as MR for Drupal 11
dillix → changed the visibility of the branch 3196018-clear-image-cache to hidden.
I created MR for resolve this issue.
Yea, I've made same kind workaround, but with hook_metatags_alter()
This patch & MR didn't help me on taxonomy pages with commerce products. Flagged products duplicated and showed first in views for anonymous users. I tried to turn off views caching for anonymous users and distinct, but its also doesn't help. There is no duplicates and sorting issue for authetificated users.
I tried on latest dev and have an issues with duplicates and same flags for anonymous users in views.
@socialnicheguru, No.
@ivnish Is this a duplicate of 🐛 Views Caching breaks anonymous Flagging Active ?
@nikolay shapovalov may be we should postpone this issue till D10 support will be ended?
I combined all oneliner patches for compatibility with D10+ into one issue: 🐛 Drupal 11 compatibility Active . So I'm closing this as duplicate.
I combined all oneliner patches for compatibility with D10+ into one issue: 🐛 Drupal 11 compatibility Active . So I'm closing this as duplicate.
I combined all oneliner patches for compatibility with D10+ into one issue: 🐛 Drupal 11 compatibility Active . So I'm closing this as duplicate.
@giuseppe87 Did you fix that issue? I have similar problem with view for categories taxonomy for commerce products.
Hi all,
I released Forum Access for D10.3 & 11 yesterday. It has migrations from FA 7.x which I tested on our clients sites. So you can add this to project page and docs. We didn't port tests from 7.x yet, so you are welcome with MR's :)
Drupal 7 has reached its EOL, so I'm closing this as outdated.
MR needs rebase for 2.0.x
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
I released 2.0.0 version of Forum Access just now.
@avpaderno I don't have permissions to create new releases.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
Drupal 7 has reached its EOL, so I'm closing this as outdated.
@nikolay shapovalov do we need to rebase your MR before merging it?
This issue was fixed as a part of ✨ Drupal 10 & 11 compatability Active .
This issue was fixed as a part of ✨ Drupal 10 & 11 compatability Active .
@salvis, Please merge ✨ Drupal 10 & 11 compatability Active if you don't plan to give me access rights to project repo.
MR in #51 doesn't pass tests on phpunit (next major). So we need fix tests.
@smulvih2 patches is not recommended now, you should add merge request.
Maintainers created 2.x branch so I mark this issue as outdated.
I fixed latest dev release in this issue: 📌 Fix Coding Standards for 2.x version Needs review
This MR is outdated I fixed last dev release here: 📌 Automated Drupal 11 compatibility fixes for ng_lightbox Needs review
I fixed all issues including right gitlab-ci.yml, tests, phpcs and phpstan warnings. Now MR goes green.
@acbramley I've added functional CI file to MR, but to pass pipelines we need to fix this issue 📌 Automated Drupal 11 compatibility fixes for ng_lightbox Needs review first and add new release for ng_lightbox.
@manishvaity you should change:
core_version_requirement: ^8 || ^9 || ^10 || ^11
to:
core_version_requirement: ^8.8 || ^9 || ^10 || ^11
This isn't actual anymore with this MR 📌 Automated Drupal 11 compatibility fixes for colorbox_load Needs review
Not actual anymore with this MR 📌 Automated Drupal 11 compatibility fixes for colorbox_load Needs review
This is not actual anymore with this MR 📌 Automated Drupal 11 compatibility fixes for colorbox_load Needs review
@longwave @larowlan this cool feature and for some reason it was removed from Image module, although the module File has it (looks like regression)
@nikolay shapovalov, I've fixed comments for constructors and arguments order for assertEquals in tests. Please review.
@nikolay shapovalov, I've fixed last suggestions from MR feedback and updated issue summary. Thanks.
Thanks @nikolay shapovalov, for fixing tests and reviewing my commits . I added final fixes with property promotion for plugin constructors. Now all pipelines in MR go green and ready for merge.