Incorrect page_title title in browser toolbar

Rerolled patch for Drupal 10.3.x

wengerk → changed the visibility of the branch 2752227-incorrect-pagetitle-title to hidden.

Openned an issue fork to run tests againts patch. I found some mistake on the rerolled patch in #50 and fix thoses issues on the Fork.
Seems to works now. I just rerolled the patch and change this code.

  public function pageTitle($page_manager_page_variant) {
    if (is_string($page_manager_page_variant)) {
        $page_manager_page_variant = $this->entityRepository->loadEntityByConfigTarget('page_variant', $page_manager_page_variant);
    }

to this

  public function pageTitle(Request $request) {
    $attributes = $request->attributes->all();
    if (!isset($attributes['_page_manager_page_variant'])) {
      return '';
    }

    if (is_string($attributes['_page_manager_page_variant'])) {
      $page_manager_page_variant = $this->entityRepository->loadEntityByConfigTarget('page_variant', $attributes['_page_manager_page_variant']);
    } elseif ($attributes['_page_manager_page_variant'] instanceof PageVariantInterface) {
      $page_manager_page_variant = $attributes['_page_manager_page_variant'];
    } else {
      return '';
    }

Fix in #51 works

Using page_manager with Drupal 11 I had to make this change:

Sorry I haven't yet made a patch, but pasting the code:

diff --git a/src/Controller/PageManagerController.php b/src/Controller/PageManagerController.php
index 6cd4edb..e952bca 100644
--- a/src/Controller/PageManagerController.php
+++ b/src/Controller/PageManagerController.php
@@ -44,27 +44,26 @@ class PageManagerController extends ControllerBase {
    * @return string
    *   The title for a particular page.
    */
-  public function pageTitle($page_manager_page_variant) {
-    if (is_string($page_manager_page_variant)) {
-      $page_manager_page_variant = $this->entityRepository->loadEntityByConfigTarget('page_variant', $page_manager_page_variant);
+   public function pageTitle(?PageVariantInterface $page_manager_page_variant) {
+    if ($page_manager_page_variant === null) {
+      // Provide a fallback title or throw an exception if a title is required.
+      return $this->t('Default Page Title');
     }
 
     // Get the variant context.
     $contexts = $page_manager_page_variant->getContexts();
-    // Get the variant page entity.
 
     $tokens = [];
-
-    foreach ($contexts as $key => $context){
+    foreach ($contexts as $key => $context) {
       $tokens[$key] = $context->getContextValue();
     }
 
     // Get the page variant page title setting.
     $variant_title_setting = $page_manager_page_variant->getPageTitle();
+
     // Load the Token service and run our page title through it.
     $token_service = \Drupal::token();
-    return $token_service->replace($variant_title_setting,
-      $tokens);
+    return $token_service->replace($variant_title_setting, $tokens);
   }
 
 }

I was using patch #50 and this was causing an error after logging into my site. Using the latest MR from #51 fixed the issue for me, and now I can login to my site without error. Posting latest patch here so I can use it in my project.

@smulvih2 patches is not recommended now, you should add merge request.

dillix → changed the visibility of the branch 8.x-4.x to hidden.

MR in #51 doesn't pass tests on phpunit (next major). So we need fix tests.