Add an "Enable Display field" checkbox to the image field

I implemented this. Don't work with existing fields. Needs to remove image field from content type and add again

Thanks for working on this old issue!

Will need test coverage and upgrade path for existing fields.

UI changes should have before/after screenshots added to issue summary.

Got the issue summary started but will need updating

Rerolled for 11.x as #20 failed to apply.

Change record draft created https://www.drupal.org/node/3468525 →

While reviewing this you need to run database updates by visiting /update.php or with drush updb

 Module   Update ID              Type          Description                                              
 -------- ---------------------- ------------- --------------------------------------------------------- 
  image    add_display_checkbox   post-update   Add a table column for "Enable Display field" checkbox.  

otherwise you will get this error

The website encountered an unexpected error. Try again later.

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_image_display' in 'where clause': SELECT 1 AS "expression" FROM "node_revision__field_image" "t" WHERE ("field_image_target_id" IS NOT NULL) OR ("field_image_display" IS NOT NULL) OR ("field_image_alt" IS NOT NULL) OR ("field_image_title" IS NOT NULL) OR ("field_image_width" IS NOT NULL) OR ("field_image_height" IS NOT NULL) LIMIT 1 OFFSET 0; Array ( ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->countFieldData() (line 1789 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

The changes are working as expected, now we have the additional checkboxes in the image field settings to display the file.

Steps to test:

1. Run database updates using drush or from update.php file
2. In the content type or any other entity type add an Image field or edit any existing image field
3. In the field settings you will find the checkboxes shown in the attached screenshots

Update hook does not appear to work.

I ran it and did a drush cex and nothing was updated
Went into admin/structure/media/manage/image/fields and resaved the field (made 0 changes)
And get new config keys.

Probably will need to update all image config that ships with core also.

@smustgrave I tested again and there are results. Needs to view Drupal Status page

1) Before patch there are no errors/warnings about any field

2) After the patch there are errors about fields

3) After updb there are no errors/warnings about any field

Config export still has no changes

We don't have any changes in configs because Image Storage ALREADY has display property in config (extended from File)

@smustgrave do we need upgrade path tests if config doesn't change?

I definitely seemed to get config changes after applying the MR. Not from the update hook but from just resaving a field form.

@smustgrave you are right, but config updated "default image uuid". It is not my patch issue. I installed clean Drupal instance, applied a patch and exported configs. I re-saved the article image field form and exported configs again. Then I compared configs.

See screenshots

Did you try

Fresh install
Export config
Apply patch
Save field
Export again?

Yes. The result in #48

Will leave it for someone else to review

@smustgrave in #47 you mean resaving the field by checking the checkbox or without any changes?

• I tested it and on just resaving the image field there are no config changes in my case either.
• By checking the checkbox, it will have a config change as the value is changing to TRUE
  display_default: true

Works fine

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

#54 issue fixed