- Status changed to Closed: outdated
16 days ago 5:46pm 14 January 2025 - 🇺🇸United States dillix
This MR is outdated I fixed last dev release here: 📌 Automated Drupal 11 compatibility fixes for ng_lightbox Needs review
First of all congrats on the great effort on this project
We're moving the 2.x version, so would be nice to take the opportunity and fix the coding standards items:
FILE: /ng_lightbox/tests/src/Functional/NgLightboxWebTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
28 | ERROR | [ ] The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /ng_lightbox/tests/src/Kernel/NgLightboxTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
23 | ERROR | [ ] The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
39 | ERROR | [x] Expected 1 blank line after function; 0 found
55 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /ng_lightbox/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 82 characters
8 | WARNING | Line exceeds 80 characters; contains 93 characters
9 | WARNING | Line exceeds 80 characters; contains 96 characters
16 | WARNING | Line exceeds 80 characters; contains 91 characters
18 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------
FILE: /ng_lightbox/src/Form/NgLightboxSettingsForm.php
------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
12 | ERROR | [x] Missing class doc comment
14 | ERROR | [ ] Missing short description in doc comment
26 | ERROR | [ ] Parameter $lightbox_renderers is not described in comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: /ng_lightbox/src/NgLightbox.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
79 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
99 | WARNING | [x] '@TODO, decide whether we want to try and support paths or to adopt routes' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
Time: 138ms; Memory: 8MB
Fix using the coding standards approach
Needs review
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This MR is outdated I fixed last dev release here: 📌 Automated Drupal 11 compatibility fixes for ng_lightbox Needs review