- ๐ฎ๐ณIndia Manoj Raj.R Chennai
Manoj Raj.R โ made their first commit to this issueโs fork.
- last update
over 1 year ago 5 pass - ๐ฎ๐ณIndia Manoj Raj.R Chennai
Hi Everyone there is new change in Readme template format.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โI have updated according to it.
Please review.
- Status changed to Needs review
over 1 year ago 5:58am 18 April 2023 - Status changed to Needs work
over 1 year ago 8:06am 18 April 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks @Manoj Raj.R! It looks good, but I still see leading spaces in most list items.
Also, there's a line break here:
- [Salvisberg Software & Consulting]( https://www.drupal.org/salvisberg-software-consulting)
- last update
over 1 year ago 5 pass - ๐ฎ๐ณIndia Manoj Raj.R Chennai
@ressa
Updated as per mentioned.Please review.
- Status changed to Needs review
over 1 year ago 8:24am 18 April 2023 - Status changed to Needs work
over 1 year ago 9:04am 18 April 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
I still see leading spaces in most list items.
- last update
over 1 year ago 5 pass - Status changed to Needs review
over 1 year ago 9:11am 18 April 2023 - ๐ฎ๐ณIndia Manoj Raj.R Chennai
Removed the List items spaces.
please review.
- Status changed to Needs work
over 1 year ago 12:36pm 18 April 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Much better, thanks! A last detail is this line:
2. It has no UI of its own and will not do anything by itself; install this module only if some other module tells you to.
Should be (three spaces before "module only ...")
2. It has no UI of its own and will not do anything by itself; install this module only if some other module tells you to.
- last update
over 1 year ago 5 pass - Status changed to Needs review
over 1 year ago 1:00pm 18 April 2023 - Status changed to Needs work
over 1 year ago 1:37pm 18 April 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks, I now see this (should be two spaces):
- Install the ACL module as you would normally install a contributed Drupal module. Visit [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-modules) for further information.
- Install the ACL module as you would normally install a contributed Drupal module. Visit [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-modules) for further information.
- Assigned to elber
- last update
over 1 year ago 5 pass - Status changed to Needs review
over 1 year ago 6:47pm 18 April 2023 - Status changed to Needs work
over 1 year ago 7:54pm 18 April 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks! The install text should not be a list item I believe:
Now
- Install the ACL module as you would normally install a contributed Drupal module. Visit [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-modules) for further information.
Better?
Install as you would normally install a contributed Drupal module. For further information, see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
- last update
over 1 year ago 5 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:16pm 18 April 2023 - ๐ง๐ทBrazil elber Brazil
Hi I agree with you now it is better. Please revise.
- ๐ฉ๐ฐDenmark ressa Copenhagen
Looks great, thanks @Manoj Raj.R and @elber.
I don't know if Earl Miles (merlinofchaos) should be removed from Maintainers, since he is not active in Drupal an longer, and xeM8VfDh, EclipseGc, id.tarzanych, and naveenvalecha added?
Let's let the maintainers decide on that.
- First commit to issue fork.
- last update
over 1 year ago 5 pass - ๐ง๐ทBrazil lucienchalom
I added all the other maintainers to the readme file, as Earl Miles (merlinofchaos) is still in the official page I will not remove them.
I also changed the list number in the configuration to follow "Ordered lists use "1", for easier updates and to avoid errors" from documentation. โ
Please review - Status changed to RTBC
over 1 year ago 1:53pm 24 May 2023 - ๐ง๐ทBrazil elber Brazil
Hi I revised the last changes (#31)
I agree with them
File looks great
Maintainers section is also correct
Moving to RTBC