- Issue created by @dillix
- π·πΊRussia zniki.ru
Hey, your progress on this issue looks amazing, but can you please split your changes to several issues/MRs, because it's difficult to review.
PHPCS fixes and Readme, Changelog changes can be moved to separate issue.
And there are several issue with similar changes:- π Replace README.txt with README.md RTBC
- π Add gitlab CI Active
- π·πΊRussia zniki.ru
I found the reason why migrate tests fails.
[#2205327]Added changes to MR 13.
And created Draft MR 14, to check if tests will pass with minimal code changes. - π·πΊRussia zniki.ru
nikolay shapovalov β changed the visibility of the branch 3493996-migrate-fix to hidden.
- πΊπΈUnited States dillix
Thanks @nikolay shapovalov, for fixing tests and reviewing my commits . I added final fixes with property promotion for plugin constructors. Now all pipelines in MR go green and ready for merge.
- π·πΊRussia zniki.ru
Thanks for your update.
Please update issue's summary and title, so MR changes is in sync with issue description.
Right now changes in the MR are much more, then current issue scope.- MR have a lot of chages out of scope of this issue.
- Removing t() from assertion.
- Tons of code style fixes.
- Replacing \Drupal::database() with DI.
- Readme and change log changes
And please check my MR feedback.
- πΊπΈUnited States dillix
@nikolay shapovalov, I've fixed last suggestions from MR feedback and updated issue summary. Thanks.
- π·πΊRussia zniki.ru
Thanks for update @dillix.
I found some more issues, please fix this. - πΊπΈUnited States dillix
@nikolay shapovalov, I've fixed comments for constructors and arguments order for assertEquals in tests. Please review.
- π·πΊRussia zniki.ru
Looking forward to merge this. I really need this for several projects.
- Issue was unassigned.
- Status changed to RTBC
about 2 months ago 2:10pm 26 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.