Drupal 10 compatibility fixes

Compatibility for drupal 10

I have added patch for the solution, please review.

@viren18febS Thanks, Verified and tested patch issue-3410468-drupal-10-compatibility-fixes.patch drupal version- 10.1.7-dev. The patch was applied successfully and looks good to me.

Testing Steps:

• Download/add the Forum Access module.
• Go to Extent> Search for the Forum Access- See the issue related to compatibility.
• Download this patch and Apply.
• Reverify compatibility issue.

Testing Results:
compatibility issue is fixed after applying the patch. RTBC ++

The last submitted patch, 8: issue-3410468-drupal-10-compatibility-fixes.patch, failed testing. View results →

Hi @all,
Added the changes to make it compatible with the D10. Kindly review the changes. Added screenshot for reference.
Thank you.

Updating this to critical. Now that D9 support has ended, this module has no supported release for modern Drupal anymore.

I am about to be testing this update on a D10 site so that I can mark it as RTBC but would be great if others also checked and marked RTBC too

Today I applied manually all shared patches here (first time in my life, I'm not a developer, I just copy pasted the proposed changes to each file in a text editor via ssh) and can now state that with Drupal 10.2.2, forum_access 8.x-1.0-beta3 and ACL 2.0.0-beta1 everything works fine. I can add new forums and folders as designed and edit their properties incl. access permissions as I'm used to do so from this module running under Drupal 9.x. Very important to know for everyone who wants to go the same path:
ONLY install/activate the forum access module AFTER you finished adding all changes to the files of the forum_access module!

Just one little thing I just observed: The forum access module is not listed yet on /web/admin/reports/updates

Thanks for your brilliant work! This makes finally possible to me to update my community website to D10, yeah!

Congrats,
Sarah

Excellent point @ChrisDarke. Looking at the code changes, it looks like this is a combination of my fix in [ 🐛 Forum access table template breaks on Drupal 10 Closed: duplicate ] and a dependency update for the ACL module. I'll count that as a code review. I have been running the module with the patch for the template issue and a composer "hack" to tell Composer ACL 2.0 should be treated as 1.1 for a while now. think you can count my vote. One thing is that @salvis says in the other issue that he can not reproduce it, which is strange and probably worth investigating. I'll mark this RTBC for now, let's see what the maintainers think.

I will make a patch compatible with D9.4 and D10 versions. But we need 2.0.x branch to commit it since we drop support for D8 version support.

I created patch for D9/10/11 compatibility. We successfully tested it and use on our production forums.
For D9.x version it uses ACL 1.1 and For D10+ it uses ACL 2.0.0-beta1 via composer. Minimum Drupal version bumped to 9.4 due to D10 compatibility fixes.

PS: This patch also contains fix for 🐛 Forum access table template breaks on Drupal 10 Closed: duplicate but I used a different approach.

The last submitted patch, 22: forum_access-3410468-22.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Updated #22 with code standards fixes to make testbot happy :)

The last submitted patch, 24: forum_access-3410468-24.patch, failed testing. View results →

I used the patch from comment 24 and fixed a conflict in the CHANGELOG.txt as well as adding one fix to a deprecated module_load_include() on merge request 7. My results using the upgrade status module show that this module is now fully compatible with D10.

For testing you can do the following since there is a change to composer.json you will need to make composer aware of the change and patches managed by composer won't do this, it must be done using a separate repository managed by composer. So you first edit your repositories section of composer.json to include a new git repository (above the exisiting drupal one so it is searched FIRST):

        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/forum_access-3410468.git"
        },

Then you edit the forum access require line to include the git repository branch name you want, this is done using:

        "drupal/forum_access": "dev-3410468-24",

Then, until the acl module has committed it's info.yml change, assuming you use the cweagans/composer-patches package to manage patches via composer, you can use the following to get the D10 patch, no repository change is necessary because no changes to composer.json are made:

          "drupal/acl": {
              "D10 compatibility": "https://www.drupal.org/files/issues/2023-12-21/acl_beta_1_drupal_10.patch"
          },

Added fix to a deprecated module_load_include() from #29 and fix for acl 2 to composer.json and module .yml

Fixed whitespace issues in CHANGELOG.TXT to make testbot happy.

Added another fix to CHANGELOG.TXT

Yet another try

I've found issue with CHANGELOG.txt, @salvis updated it after I pulled 8.x-1x repo. So I hope this patch will be ok.

The last submitted patch, 34: forum_access-3410468-34.patch, failed testing. View results →

As I see #34 was build succesfully for D9.5 & D10 and there isn't any errors found by testbot.

I also fixed deprecation of user_roles() with OOP equivalent, so now module should be compatible with Drupal 11 too:)

Hello,
I used this module forum_access on my drupal 9 website, i upgrade my website on drupal 10 but impossible to upgrade forum_access on my website and keep it. Do you know how far you are from a final patch available on drupal 10 ? Do you need any help about that ?

@Cedrick we need new branch for D9.5-D11 to apply my patch, because FA 8.x-1.x needs ACL 1.x... I asked @salvis to create new branch, but he didn't respond and I don't have access rights to git.

Thanks dillix.

I succeed to apply the patch by building a new one from what you i've shared.
I used Lenient to push the modules on drupal 10.2.6 :

• acl v1.1
• forum_access v1.0

To complete my previous patch i buld a new patch.
After some tests i found an issue : If no moderators are set it is not possible to create a new forum.

So this patch could be associated to the previous one (#42) on drupal 10

@cedrick Please open new issue and post your patch from #43 there. This issue about porting to D10 & D11.