Thanks to @ volkswagenchick for putting in so much energy to helping keep things afloat the last few years, you deserve a bit of a rest too! I will keep trying to get the charter sorted out, and as long as I can afford it will be going to as many events as possible along with the time spent during the month on comms and planning.
I plan to get this done by the end of this week to update the MR
Please review credited users, should be good to go
Adding the credits for the users listed above
Mentors during mentored contrib day:
@Amarshall
@greggmarshall
@mradcliffe
@sushyl
@xjm
@ChrisDarke
@volkswagenchick
@ultimike
@rfay
@leslieg
@Farnoosh
@markie
@joshmiller
@Anilu@
@dalin
@kristen-pol
@shaal
@capysara
@rachel_norfolk
The MR information covering the changes on source branches has changed since this was written. There is no option for rebasing on gitlab now.
Adding information regarding resolving issues with Authorization
ChrisDarke → created an issue.
I am mentoring this team working on resolving this issue during Contrib Day DrupalCon Portland 2024. I will be committing to working on this for today 8th of May 2024.
ChrisDarke → changed the visibility of the branch 3444906-mentoring-playground-issue to active.
ChrisDarke → changed the visibility of the branch 3444906-mentoring-playground-issue to hidden.
ChrisDarke → created an issue.
ChrisDarke → created an issue.
Please review
Declaring the drush service in its own services yaml resolves this issue, when defined in the main services yml it doesn't seem to detect it any more.
Ideally attributes would also be set on the commands along with annotations for future proofing but for now this resolves the issue. I tested by applying the patch generated from the MR diff on my local 10.2.5 instance.
Ready for RTBC.
ChrisDarke → made their first commit to this issue’s fork.
We no longer use the cards, they have not been updated or used in about 3 years at least.
rachel_norfolk → credited ChrisDarke → .
I am about to be testing this update on a D10 site so that I can mark it as RTBC but would be great if others also checked and marked RTBC too
ChrisDarke → made their first commit to this issue’s fork.
Resolved test failing due to schema config error.
ChrisDarke → made their first commit to this issue’s fork.
Adding bullets for BoFs
ChrisDarke → created an issue.
volkswagenchick → credited ChrisDarke → .
apaderno → credited ChrisDarke → .
Indeed! But getting it RTBCed is the fastest way to getting it into release :)
Just wanted to clarify so that it didn’t cause pushback on the otherwise working MR
@Guido_S see the target version for this issue. I would recommend switching to 3.0.x-dev and retesting.
Rebuild the MR for the target branch 3.x, which allowed the diff to be installed via composer patches.
https://git.drupalcode.org/project/addtocal/-/merge_requests/8/diffs
This removes the redundant diff lines that were caused by it targeting 8.x-2.x
Looks to be working
ChrisDarke → made their first commit to this issue’s fork.
@Maintainers, is there a timeline for getting some of these 3.0.0-beta1 issues resolved? I am at the point where multiple composer patches are conflicting. If no one is able to commit time to this project feel free to put out an issue looking for co-maintainers so we can get some of these issues past the finish line, cheers!
@Sebastian Hagens, maybe you could reach out to the module maintainers and offer to help maintain the module if you have the time. There is a process for this as outlined here:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
Let me know if you need a hand with that, I don't have time myself but I am happy to provide support.
Cheers!
Chris
For those of you uploading patches of the MR for use in composer patches etc, why not just use the autogenerated patch from the diff?
Eg. https://git.drupalcode.org/project/rate/-/merge_requests/11.diff or https://git.drupalcode.org/project/rate/-/merge_requests/11.patch (in this case Patch doesn't like to apply as it has multiple commits but diff works correctly)
(Just add .patch or .diff to the end of the MR URL)
For what its worth, the MR applies and resolves the issue.
Looks like this is needed after all
Oops forgot this was done!
Changing status to 'needs review' as the MR has been submitted
Please review PR, change is very simple
ChrisDarke → created an issue.
volkswagenchick → credited ChrisDarke → .
@Berdir, the issue that I was able to replicate with 8.x-1.x was that PathautoFieldItemList::computeValue() was getting a null value from $this->getEntity()->id(), which can happen.. unless I misunderstand there can be cases where enforceIsNew is set but id is null.
I added an updated MR that successfully installs and fixes the issue on my local instance.
ChrisDarke → made their first commit to this issue’s fork.
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
ChrisDarke → created an issue. See original summary → .
Hi @alt.dev, @labboy0276, hows that going?
volkswagenchick → credited ChrisDarke → .
ChrisDarke → created an issue.
Looks like the module maintainers are possibly too busy?
If anyone needs this module and wants to take over maintainership of it, this is the guide to take ownership of the module.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
I don't have time to do so myself but I will happily help guide someone through the process.
Anyone waiting on this who wants to take over ownership of this module? I can help start the process following the steps outlined here:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
Let me know if you would like support with this, don't have time to be supporting another module myself but I am happy to help guide through the process.
Cheers!
Updating with corrections and another item
Thanks AmyJune! I do have this on my calendar for today and you beat me to it!
ChrisDarke → created an issue.
Adding merge request
ChrisDarke → created an issue.
volkswagenchick → credited ChrisDarke → .
@sdstyles, if you wish to get some co-maintainers in to help with things like this, let us know.
Hi @urvashi_vora, please take a look at this guide, it outlines the steps involved:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
Let me know if you need more information.
Does someone want to volunteer to take over maintainership of this module if the maintainers do not want wish to keep it up to date?
Adding Fork and merge request.
Updated Remaining tasks and status.
ChrisDarke → created an issue.
volkswagenchick → credited ChrisDarke → .
ChrisDarke → created an issue. See original summary → .
volkswagenchick → credited ChrisDarke → .
I ran the first time contribution workshops and then tried to help out where possible in the mentored contribution room at various tables.
Forgot to mention I am on PHP 8.1.18.
I have create a Merge Request that resolves this settings issue for me.
Basically some of the form elements in the Settings form were passing an array in as a default value to the checkbox element.
Updated the Remaining Tasks.
I am getting this error with 5.0.x-dev and 5.0.0.
The console shows:
{
"message": "\nAn AJAX HTTP error occurred.\nHTTP Result Code: 200\nDebugging information follows.\nPath: /admin/structure/views/ajax/display/test_carousel_view/block_1/style_options\nStatusText: OK\nResponseText: Warning: Array to string conversion in /app/web/core/lib/Drupal/Core/Render/Element/Checkbox.php on line 129\n[{\"command\":\"settings\",\"settings\":
....
}
So 5.0 did not fix the issue for me.
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
volkswagenchick → credited ChrisDarke → .
ChrisDarke → created an issue.
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
Migrating tags to do tag cleanup