- Issue created by @joachim
- ๐ฌ๐งUnited Kingdom joachim
git blame shows this dates back to when the interface was added in 9da7e4cdc7c2c289b9af079d22fcfd862121a903 in 2014:
> Issue #2169267 by damiankloip: Replace drupal_cron_run() with a Cron service.
git describe says:
> 8.0-alpha8-78-g9da7e4cdc7
And Simpletest was replaced with PHPUnit around 2016 -- #1567500: [meta] Pave the way to replace the testing framework with PHPUnit and possibly rewrite Simpletest โ .
So yes, it looks like this comment dates from the Simpletest era and can simply be removed.
I'll file a follow-up to look into removing CronRunTrait.
- Assigned to Nicolas_Barbarisi
- Status changed to Needs work
about 1 year ago 2:14pm 19 October 2023 - ๐ซ๐ทFrance Nicolas_Barbarisi
As I understand it, the documentation regarding the execution of cron tasks in tests is outdated and needs to be updated. If it's ok, I can take care of it.
- Merge request !5052Resolve #3340299 "Documentation in croninterface" โ (Open) created by Nicolas_Barbarisi
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 30,420 pass - Status changed to Needs review
about 1 year ago 10:51pm 19 October 2023 - ๐ซ๐ทFrance Nicolas_Barbarisi
Work is done for me. Tell me if the doc is too long, I will shorten it.
- Status changed to RTBC
about 1 year ago 3:53pm 23 October 2023 - ๐บ๐ธUnited States smustgrave
From my standpoint that reads well and clearly provides more detail then currently there.
- last update
about 1 year ago 30,427 pass - last update
about 1 year ago 30,437 pass - last update
about 1 year ago 30,442 pass - Status changed to Needs work
about 1 year ago 9:58pm 27 October 2023 - ๐ช๐ธSpain davidjguru Seville, Andalusia (Spain)
Lines wrapped at 80 characters and other changes in files:
* CronInterface.php
* Cron.phpBy executing:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/CronInterface.phpFILE: /var/www/html/core/lib/Drupal/Core/CronInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 87 characters
19 | WARNING | Line exceeds 80 characters; contains 110 characters
22 | WARNING | Line exceeds 80 characters; contains 82 characters
23 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------Time: 87ms; Memory: 6MB
And:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/Cron.phpFILE: /var/www/html/core/lib/Drupal/Core/Cron.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------
97 | ERROR | [x] Parameter comment must end with a full stop
125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
130 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
169 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
314 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------Two new patches were added to the issue and changes were commited to the repository fork, waiting now in a MR.
- Status changed to Needs review
10 months ago 3:48pm 27 January 2024 - Status changed to Needs work
9 months ago 5:23pm 9 February 2024 - ๐บ๐ธUnited States smustgrave
As mentioned needs a rebase to hopefully fix the cspell issue.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 6:14pm 17 April 2024 - ๐ฎ๐ณIndia adwivedi008
Updated the MR-5052
Rebased to 11.xPlease review if any other changes are required.
- Status changed to Needs work
7 months ago 4:41pm 19 April 2024 - ๐ฎ๐ณIndia pradhumanjainOSL
pradhumanjain2311 โ made their first commit to this issueโs fork.
- Status changed to Needs review
6 months ago 6:35pm 7 May 2024 - ๐บ๐ธUnited States mradcliffe USA
I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think we can update the issue summary based on recent work on the issue. I changed the status to Needs review because this could be a Novice task for reviewing a merge request.
- Issue was unassigned.
- ๐บ๐ธUnited States cpierce42
My name is Caleb, I am assisting with this issue at DrupaCon Portland 2024.
My name is Jeremiah Haynes, and I will be working on this issue at DrupalCon 2024. I can dedicate the rest of the afternoon (5/8/2024) to this issue.
- ๐บ๐ธUnited States thomas.crouch
My name is Thomas, and assisting Caleb with this issue at DrupalCon 2024.
From DrupalCon Portland 2024, Chris Darke is helping me as a first-time contributor with working on this issue.
Hi, my name is John Brooks and I'm helping with this issue from DrupalCon Portland 2024. Chris Darke mentoring.
- ๐ฌ๐งUnited Kingdom ChrisDarke London
I am mentoring this team working on resolving this issue during Contrib Day DrupalCon Portland 2024. I will be committing to working on this for today 8th of May 2024.
- ๐บ๐ธUnited States cpierce42
Discussed at DrupalCon Portland 2024 with 5 devs. Adding full stop periods back in as it complies with code standards.
Ref: https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... โ Bullet point 12John is making the commit now.
- Status changed to Needs work
6 months ago 11:39pm 9 May 2024