documentation in CronInterface is out of date and incomplete

git blame shows this dates back to when the interface was added in 9da7e4cdc7c2c289b9af079d22fcfd862121a903 in 2014:

> Issue #2169267 by damiankloip: Replace drupal_cron_run() with a Cron service.

git describe says:

> 8.0-alpha8-78-g9da7e4cdc7

And Simpletest was replaced with PHPUnit around 2016 -- #1567500: [meta] Pave the way to replace the testing framework with PHPUnit and possibly rewrite Simpletest → .

So yes, it looks like this comment dates from the Simpletest era and can simply be removed.

I'll file a follow-up to look into removing CronRunTrait.

As I understand it, the documentation regarding the execution of cron tasks in tests is outdated and needs to be updated. If it's ok, I can take care of it.

Work is done for me. Tell me if the doc is too long, I will shorten it.

From my standpoint that reads well and clearly provides more detail then currently there.

Lines wrapped at 80 characters and other changes in files:
* CronInterface.php
* Cron.php

By executing:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/CronInterface.php

FILE: /var/www/html/core/lib/Drupal/Core/CronInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 87 characters
19 | WARNING | Line exceeds 80 characters; contains 110 characters
22 | WARNING | Line exceeds 80 characters; contains 82 characters
23 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------

Time: 87ms; Memory: 6MB

And:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/Cron.php

FILE: /var/www/html/core/lib/Drupal/Core/Cron.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------
97 | ERROR | [x] Parameter comment must end with a full stop
125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
130 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
169 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
314 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

Two new patches were added to the issue and changes were commited to the repository fork, waiting now in a MR.

As mentioned needs a rebase to hopefully fix the cspell issue.

Updated the MR-5052
Rebased to 11.x

Please review if any other changes are required.

Small comments.

pradhumanjain2311 → made their first commit to this issue’s fork.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think we can update the issue summary based on recent work on the issue. I changed the status to Needs review because this could be a Novice task for reviewing a merge request.

My name is Caleb, I am assisting with this issue at DrupaCon Portland 2024.

My name is Jeremiah Haynes, and I will be working on this issue at DrupalCon 2024. I can dedicate the rest of the afternoon (5/8/2024) to this issue.

My name is Thomas, and assisting Caleb with this issue at DrupalCon 2024.

From DrupalCon Portland 2024, Chris Darke is helping me as a first-time contributor with working on this issue.

Hi, my name is John Brooks and I'm helping with this issue from DrupalCon Portland 2024. Chris Darke mentoring.

I am mentoring this team working on resolving this issue during Contrib Day DrupalCon Portland 2024. I will be committing to working on this for today 8th of May 2024.

Discussed at DrupalCon Portland 2024 with 5 devs. Adding full stop periods back in as it complies with code standards.
Ref: https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... → Bullet point 12

John is making the commit now.

Reviewed and Tested

Hi all,
I have resolved the conflicts and reverted the method's argument definition as suggested MR! 5052. Let me know if any further adjustments are needed.

Thanks!

Since this was tagged for novice be good practice for issue summary but proposed solution should not be empty

Hi @smustgrave

I've now added a clear Proposed resolution section to the issue summary, describing the adjustments made to the PHPDoc and how it addresses the original problem.
Let me know if anything else needs to be clarified.

Believe feedback has been addressed.