🇺🇸United States @cpierce42

cpierce42 → created an issue.

cpierce42 → created an issue.

patch 14 allows stage file proxy to work with svg_image 3.1.0

I disagree Arialblack, Ticket should stay open. We are not trying to exclude svg we are trying to have them render correctly. Testing latest patch.

I haven't had time to work on writing tests but I did re roll 16 to make it work again.

Uploaded patch with proposed solution.

cpierce42 → created an issue.

Core has nightwatch as optional test running. Could that be extended to use the Visual Regression testing add on?

I have tested this and confirms the patch fixes my issue. Thank you for your efforts!

Actually I take that back. When I deploy to an Acquia server via pipelines I get a lockout where I cannot run "composer clear" to clear composer cache. Drush cache clear works normally but does not resolve WSOD.

Adding a note incase anyone else has a similar environment to mine:
Lando, drupal 10.x, docker.
I needed to run `composer update --prefer-dist`, `lando composer clear` and then `composer clear` before drush commands would run.

#2 solved my issue. I thought something was seriously wrong when my menu links disappeared.

This is still not released. Downloading the latest tb_megamenu the patch is not present as of 3.x-apha-4.
Thought I would mention it in case anyone else is having the same problem thinking it is fixed.

Adding my +1 for reviews. #5 works for me.

Same issue today as others. Plus 1 on the RTBC! #9 works great for me.

Tested #16 and it fails to patch. block_visibility_groups_admin/src/Tests/GroupListerTest.php is the wrong location and case. Location should be block_visibility_groups_admin/tests/Functional/GroupListerTest.php

Discussed at DrupalCon Portland 2024 with 5 devs. Adding full stop periods back in as it complies with code standards.
Ref: https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... → Bullet point 12

John is making the commit now.

My name is Caleb, I am assisting with this issue at DrupaCon Portland 2024.

+2, I also confirmed this bug and this patch works.

Fixed deprecation error in Trim() by typecasting (string). Patch works good for me.
I wish this would get merged in.

cpierce42 → created an issue.

Merge request #4 fails when running `drush cim -y` patch fails to fix.

example config file that fails:

debug: false
cron_interval: null
cron_interval_override: null
hide_signup_messages: 0
third_party_settings: null

Error stack:

$ drush cim -y
 [warning] Undefined array key "ignored" ConfigSplitIgnoreFilter.php:186
 [warning] Undefined array key "ignored" ConfigSplitIgnoreFilter.php:172
 [error]  TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() (line 172 of /app/docroot/modules/contrib/config_split_ignore/src/Plugin/ConfigFilter/ConfigSplitIgnoreFilter.php) #0 /app/docr
oot/modules/contrib/config_split_ignore/src/Plugin/ConfigFilter/ConfigSplitIgnoreFilter.php(172): in_array('!acquia_connect...', NULL, true)
#1 /app/docroot/modules/contrib/config_filter/src/Config/FilteredStorage.php(61): Drupal\config_split_ignore\Plugin\ConfigFilter\ConfigSplitIgnoreFilter->filterExists('acquia_connecto...', true)
#2 /app/docroot/modules/contrib/config_filter/src/Config/FilteredStorage.php(182): Drupal\config_filter\Config\FilteredStorage->exists('acquia_connecto...')

Patch #3 worked for me.

Related issue #9 did not work for me in this bug by it's self when running drush commands.

Both patches do work together.

My environment:
D10.2
config_ignore: 3.2
config_filter: 2.6
config_split_ignore: 1.10

According to this page there is no equivalent for fakeobjects.

The ckeditor people just a link to "custom widgets" page that is a lengthy tutorial on adding your own widget.

This patch still fails for me because the composer.json still relies upon "cweagans/php-webdam-client": "^1.0.1", when running composer update

Please see comment #7 for more details.

Thanks for working on this! I also want to upgrade to Drupal 10 but am trapped on Acquia DAM Classic.

This fails for me because php-web-dam project is abandoned https://packagist.org/packages/cweagans/php-webdam-client
Composer feeds back:

Problem 1
    - Root composer.json requires drupal/media_acquiadam ^1.45 -> satisfiable by drupal/media_acquiadam[1.45.0, ..., 1.x-dev].
    - Conclusion: don't install guzzlehttp/psr7 2.5.0 (conflict analysis result)

and

~/projects/testdir$ composer depends guzzlehttp/psr7
cweagans/php-webdam-client  1.0.1  requires  guzzlehttp/psr7 (~1.0)    
drupal/core-recommended     9.5.9  requires  guzzlehttp/psr7 (~1.9.1)
guzzlehttp/guzzle           6.5.8  requires  guzzlehttp/psr7 (^1.9)

The composer.json inside media_acquiadam folder contains:

 "require": {
        "cweagans/php-webdam-client": "^1.0.1",

I am interested in having this module ready for d10 also. I emailed @energee. Hopefully he sees my message soon.

There wasn't a test available for the 2.0.0alpha7

cpierce42 → created an issue.

Reviewed and tested. Patch #5 works make D9 more compatible with php 8.1

This patch works great for me and immediately solved my problem. Rerolled for 2.0.x-dev
(Seems there is no "test with" option for 2.0.x-dev) for automated testing.

Hello,
I am writing to report that #16 successfully fixes the issue in this ticket and am adding a +2 review.
I was battling it for quite a while before I stumbled upon this ticket.

Patch #16 confirmed works on:

• Drupal 9.5.3
• PHP 8.0.27 (cli) (built: Jan 11 2023 08:21:13) ( NTS )
• Rabbit hole 1.0.0-beta11

Please merge!

Patch does not apply on version 1.1x of this module.
Drupal 9.5.2