🇺🇸United States @cpierce42

I've been experimenting with this in lando (wsl2, drupal 10.4) tying to upgrade nightwatchjs to version 3.11.0.
This ticket https://www.drupal.org/project/drupal/issues/3371963#comment-15134159 📌 Update Nightwatch to 3.x Fixed said it would be ported into D10.3+ but it did not get rolled in.

I am attempting to re-work the merge reqeust that was submitted and making it work but there is something missing.

I got it pretty close where it starts a selenium server but hangs:

Starting Selenium Server [selenium-server-4.20.0.jar] on port 9515...

Nothing else happens and the log file is blank.

Specifically to get to this point I preformed the following steps:
write a patch to allow changes from the above mentioned ticket to apply in composer
Install linux current chromium driver on both wsl and in the lando build_as_root apt install libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev

In my lando file I have a lot of changes:

  appserver:
    webroot: docroot
    xdebug: 'develop,debug'
    ssl: true
    config:
      php: .lando.php.ini
    build_as_root:
      # Nightwatch config
      - curl -sL https://deb.nodesource.com/setup_18.x | bash -
      - apt install libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev
      - apt-get install -y nodejs
      - npm install -g yarn
    run:
      - mkdir -p private/browsertest_output
      - yarn add @nightwatch/vrt --cwd /app/docroot/core
      - yarn add @nightwatch/selenium-server --cwd /app/docroot/core
      - yarn install --non-interactive --cwd /app/docroot/core
      # Override nightwatch config to our custom config that includes vrt
      # This will break on upgrade to drupal 11. Nightwatch tests will need to be upgraded to api v3
# copy my saved .env and config file into the core folder to ease of setup and testing
      - cp /app/Nightwatch/nightwatch.conf.js /app/docroot/core/tests/Drupal/Nightwatch/nightwatch.conf.js
      - cp /app/Nightwatch/.env /app/docroot/core/.env
    overrides:
      environment:
        # Support debugging CLI with Xdebug.
        PHP_IDE_CONFIG: "serverName=appserver"
        # nightwatch config, probably not needed as we have the .env file
        SIMPLETEST_BASE_URL: "https://mytest.lndo.site"
        SIMPLETEST_DB: "mariadb://drupal10:drupal10@database:3306/drupal10"
        BROWSERTEST_OUTPUT_DIRECTORY: '/app/docroot/sites/simpletest/browser_output'
        BROWSERTEST_OUTPUT_BASE_URL: 'https://mytest.lndo.site'
        MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", {"browserName":"chrome","chromeOptions":{"args":["--disable-gpu","--headless","--no-sandbox"]}}, "http://chrome:9515"]'        # Nightwatch
        DRUPAL_TEST_BASE_URL: 'https://mytest.lndo.site'
        DRUPAL_TEST_DOCKER: TRUE
        DRUPAL_TEST_DB_URL: 'mariadb://drupal10:drupal10@database:3306/drupal10'
        DRUPAL_TEST_WEBDRIVER_HOSTNAME: chrome
        DRUPAL_TEST_WEBDRIVER_PORT: 9515
        DRUPAL_TEST_CHROMEDRIVER_AUTOSTART: 'false'
        DRUPAL_TEST_WEBDRIVER_CHROME_ARGS: "--disable-gpu --headless --no-sandbox"
        DRUPAL_NIGHTWATCH_OUTPUT: ./reports/nightwatch
        DRUPAL_NIGHTWATCH_IGNORE_DIRECTORIES: node_modules,vendor,.*,sites/*/files,sites/*/private,sites/simpletest
  chrome:
    type: compose
    scanner: false
    app_mount: false
    services:
      image: drupalci/chromedriver:production
      expose:
        - "9515"
        - "4444"
      volumes:
        - /dev/shm:/dev/shm
      security_opt:
        - seccomp:unconfined
      command: ["chromedriver",  "--log-path=/tmp/chromedriver.log", "--verbose", "--allowed-ips=", "--allowed-origins=*", "--whitelisted-ips="]
      external_links:
      - appserver:mytest.lndo.site

In the nightwatch.config.js file I changed the selenium start_process to true, added plugins:['@nightwatch/vrt']

Seems this is a E.B.K.A.C. Error. Please ignore.

cpierce42 → created an issue.

Your input was very helpful.

Maybe I can illustrate better with an image.

In capture.png you can see the bootstrap 'sub-theme/node_modules/bootstrap/scss/_button.scss' style of .btn has more priority than my .btn in 'sub-theme/component/button/button.scss'

I do not know how to make my scss elements take more priority in my subtheme.

cpierce42 → created an issue.

cpierce42 → created an issue.

cpierce42 → created an issue.

patch 14 allows stage file proxy to work with svg_image 3.1.0

I disagree Arialblack, Ticket should stay open. We are not trying to exclude svg we are trying to have them render correctly. Testing latest patch.

I haven't had time to work on writing tests but I did re roll 16 to make it work again.

Uploaded patch with proposed solution.

cpierce42 → created an issue.

Core has nightwatch as optional test running. Could that be extended to use the Visual Regression testing add on?

I have tested this and confirms the patch fixes my issue. Thank you for your efforts!

Actually I take that back. When I deploy to an Acquia server via pipelines I get a lockout where I cannot run "composer clear" to clear composer cache. Drush cache clear works normally but does not resolve WSOD.

Adding a note incase anyone else has a similar environment to mine:
Lando, drupal 10.x, docker.
I needed to run `composer update --prefer-dist`, `lando composer clear` and then `composer clear` before drush commands would run.

#2 solved my issue. I thought something was seriously wrong when my menu links disappeared.

This is still not released. Downloading the latest tb_megamenu the patch is not present as of 3.x-apha-4.
Thought I would mention it in case anyone else is having the same problem thinking it is fixed.

Adding my +1 for reviews. #5 works for me.

Same issue today as others. Plus 1 on the RTBC! #9 works great for me.

Tested #16 and it fails to patch. block_visibility_groups_admin/src/Tests/GroupListerTest.php is the wrong location and case. Location should be block_visibility_groups_admin/tests/Functional/GroupListerTest.php

Discussed at DrupalCon Portland 2024 with 5 devs. Adding full stop periods back in as it complies with code standards.
Ref: https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... → Bullet point 12

John is making the commit now.

My name is Caleb, I am assisting with this issue at DrupaCon Portland 2024.

+2, I also confirmed this bug and this patch works.

Fixed deprecation error in Trim() by typecasting (string). Patch works good for me.
I wish this would get merged in.

cpierce42 → created an issue.

Merge request #4 fails when running `drush cim -y` patch fails to fix.

example config file that fails:

debug: false
cron_interval: null
cron_interval_override: null
hide_signup_messages: 0
third_party_settings: null

Error stack:

$ drush cim -y
 [warning] Undefined array key "ignored" ConfigSplitIgnoreFilter.php:186
 [warning] Undefined array key "ignored" ConfigSplitIgnoreFilter.php:172
 [error]  TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() (line 172 of /app/docroot/modules/contrib/config_split_ignore/src/Plugin/ConfigFilter/ConfigSplitIgnoreFilter.php) #0 /app/docr
oot/modules/contrib/config_split_ignore/src/Plugin/ConfigFilter/ConfigSplitIgnoreFilter.php(172): in_array('!acquia_connect...', NULL, true)
#1 /app/docroot/modules/contrib/config_filter/src/Config/FilteredStorage.php(61): Drupal\config_split_ignore\Plugin\ConfigFilter\ConfigSplitIgnoreFilter->filterExists('acquia_connecto...', true)
#2 /app/docroot/modules/contrib/config_filter/src/Config/FilteredStorage.php(182): Drupal\config_filter\Config\FilteredStorage->exists('acquia_connecto...')

Patch #3 worked for me.

Related issue #9 did not work for me in this bug by it's self when running drush commands.

Both patches do work together.

My environment:
D10.2
config_ignore: 3.2
config_filter: 2.6
config_split_ignore: 1.10

According to this page there is no equivalent for fakeobjects.

The ckeditor people just a link to "custom widgets" page that is a lengthy tutorial on adding your own widget.

This patch still fails for me because the composer.json still relies upon "cweagans/php-webdam-client": "^1.0.1", when running composer update

Please see comment #7 for more details.

Thanks for working on this! I also want to upgrade to Drupal 10 but am trapped on Acquia DAM Classic.

This fails for me because php-web-dam project is abandoned https://packagist.org/packages/cweagans/php-webdam-client
Composer feeds back:

Problem 1
    - Root composer.json requires drupal/media_acquiadam ^1.45 -> satisfiable by drupal/media_acquiadam[1.45.0, ..., 1.x-dev].
    - Conclusion: don't install guzzlehttp/psr7 2.5.0 (conflict analysis result)

and

~/projects/testdir$ composer depends guzzlehttp/psr7
cweagans/php-webdam-client  1.0.1  requires  guzzlehttp/psr7 (~1.0)    
drupal/core-recommended     9.5.9  requires  guzzlehttp/psr7 (~1.9.1)
guzzlehttp/guzzle           6.5.8  requires  guzzlehttp/psr7 (^1.9)

The composer.json inside media_acquiadam folder contains:

 "require": {
        "cweagans/php-webdam-client": "^1.0.1",

I am interested in having this module ready for d10 also. I emailed @energee. Hopefully he sees my message soon.

There wasn't a test available for the 2.0.0alpha7

cpierce42 → created an issue.

Reviewed and tested. Patch #5 works make D9 more compatible with php 8.1

This patch works great for me and immediately solved my problem. Rerolled for 2.0.x-dev
(Seems there is no "test with" option for 2.0.x-dev) for automated testing.

Hello,
I am writing to report that #16 successfully fixes the issue in this ticket and am adding a +2 review.
I was battling it for quite a while before I stumbled upon this ticket.

Patch #16 confirmed works on:

• Drupal 9.5.3
• PHP 8.0.27 (cli) (built: Jan 11 2023 08:21:13) ( NTS )
• Rabbit hole 1.0.0-beta11

Please merge!

Patch does not apply on version 1.1x of this module.
Drupal 9.5.2