string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Reviewed and tested. Patch #5 works make D9 more compatible with php 8.1

A bit confused that this hasn't bitten us yet, maybe PHP isn't actually enforcing it, but also just test code and an easy change.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

We haven't run into it because its not a problem to use String as a namespace:

https://3v4l.org/RDj7e

PHPUnit actually uses a String namespace:
https://github.com/sebastianbergmann/phpunit/tree/main/src/Framework/Con...

Actually, the answer is in the docs:

"The following words cannot be used to name a class, interface or trait. Prior to PHP 8.0, they are also prohibited from being used in namespaces."
https://www.php.net/manual/en/reserved.other-reserved-words.php

Automatically closed - issue fixed for 2 weeks with no activity.