- πΊπΈUnited States mlncn Minneapolis, MN, USA
Needs reroll, sorry.
This should be applied against the 2.0.x branch, just had our first (Drupal 10 compatible) release there, will commit this to there so it is available on dev branch immediately.
- πΊπΈUnited States cpierce42
This patch works great for me and immediately solved my problem. Rerolled for 2.0.x-dev
(Seems there is no "test with" option for 2.0.x-dev) for automated testing. - last update
about 1 year ago PHPLint Failed - last update
about 1 year ago 12 pass - πΊπΈUnited States DamienMcKenna NH, USA
This hopefully fixes the tests.
- Status changed to Needs work
about 1 year ago 12:06pm 30 March 2024 - πΊπΈUnited States cpierce42
Tested #16 and it fails to patch.
block_visibility_groups_admin/src/Tests/GroupListerTest.php
is the wrong location and case. Location should beblock_visibility_groups_admin/tests/Functional/GroupListerTest.php
- πΊπΈUnited States cpierce42
I haven't had time to work on writing tests but I did re roll 16 to make it work again.
- πΊπΈUnited States ccjjmartin Austin, TX
I had to capitalize the S in the Settings file. Updated patch to #19 provided.
- πΊπΈUnited States ccjjmartin Austin, TX
Bug in the current functionality. I did not understand how the module works so I added a condition group to itself thus creating a recursive loading of itself infinitely and breaking the site due to an exhausted memory PHP failure. Recommend editing this patch to check the active page and remove the active condition group from the available condition groups within the dropdown.
Also, while these features could co-exist, a reminder for everyone on the thread that this was merged in the next minor version release of the module 2.1.x and may supersede this patch: https://www.drupal.org/project/block_visibility_groups/issues/2864027 β¨ Allow choosing more than 1 visibility group per block Needs work