Allow choosing more than one visibility group per block

Working on a reroll.

Rerolled. Hopefully.

While there is an update script for fixing the configuration, would it be worth including logic in buildConfigurationForm(), calculateDependencies(), getCacheTags(), getCacheContexts() and getCacheMaxAge() to support a single value?

(waiting for the v2 tests to be enabled, then I'll finish off any issues that arise on this issue)

This should go into a 2.1.x release, as it's a new feature.

Rerolled.

The last submitted patch, 23: block_visibility_groups-n2864027-23.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Rerolled.

The last submitted patch, 25: block_visibility_groups-n2864027-25.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Trying to fix those tests.

The last submitted patch, 27: block_visibility_groups-n2864027-27.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Trying to debug this from the runtime output as it's failing locally because of something else.

Will this fix it?

The last submitted patch, 29: block_visibility_groups-n2864027-29.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Trying again.

Now without that typo.

The last submitted patch, 33: block_visibility_groups-n2864027-33.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The config value was only partially renamed from 'block_visibility_group' to 'block_visibility_groups', a few uses of the older argument existed so let's see if this is better.

The last submitted patch, 35: block_visibility_groups-n2864027-35.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

This fixes the problem locally.

The last submitted patch, 37: block_visibility_groups-n2864027-37.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

This should fix it.

The last submitted patch, 39: block_visibility_groups-n2864027-39.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Let's see if this fixes the problem.

The last submitted patch, 41: block_visibility_groups-n2864027-41.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Once more.

The last submitted patch, 43: block_visibility_groups-n2864027-43.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 45: block_visibility_groups-n2864027-45.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 47: block_visibility_groups-n2864027-47.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 49: block_visibility_groups-n2864027-49.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The patch #49 is not applying for me.

Can confirm that patch block_visibility_groups-n2864027-49.patch → does not apply to the latest 2.0.x-dev

Ravi: please don't upload screenshots of patches applying, or not applying, it's a waste of space and time.

I've created a MR based on the last patch.

The MR tests fail.

I fixed the tests, but had to disable some of the assertions in testVisibilityGroupLocked().. and I think it might need some review.

Thanks @DamienMcKenna for your work on this. Patch works again with 2.0.x-dev

Functionally it's working, will deal with the test issues separately.

Committed. Thank you everyone!

Automatically closed - issue fixed for 2 weeks with no activity.