Seville, Andalusia (Spain)
Account created on 12 November 2010, over 13 years ago
  • Senior Drupal Developer at FFWΒ 
  • Member at AEDΒ  …
#

Recent comments

πŸ‡ͺπŸ‡ΈSpain davidjguru Seville, Andalusia (Spain)

drush ev '\Drupal::entityTypeManager()->getStorage("shortcut_set")->load("default")->delete();'

πŸ‡ͺπŸ‡ΈSpain davidjguru Seville, Andalusia (Spain)

Hi,
I'm getting the same error using:
Drupal - 10.2.6
Drush - 12.5.2.0
Guttemberg - 3.0@beta

πŸ‡ͺπŸ‡ΈSpain davidjguru Seville, Andalusia (Spain)

Lines wrapped at 80 characters and other changes in files:
* CronInterface.php
* Cron.php

By executing:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/CronInterface.php

FILE: /var/www/html/core/lib/Drupal/Core/CronInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 87 characters
19 | WARNING | Line exceeds 80 characters; contains 110 characters
22 | WARNING | Line exceeds 80 characters; contains 82 characters
23 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------

Time: 87ms; Memory: 6MB

And:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/lib/Drupal/Core/Cron.php

FILE: /var/www/html/core/lib/Drupal/Core/Cron.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------
97 | ERROR | [x] Parameter comment must end with a full stop
125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
130 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
169 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
314 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

Two new patches were added to the issue and changes were commited to the repository fork, waiting now in a MR.

πŸ‡ͺπŸ‡ΈSpain davidjguru Seville, Andalusia (Spain)

Hi there! I just ran PHPCS around the updated file and I got some feedback.

I ran this in LDE:
$ ddev exec phpcs --standard="Drupal,DrupalPractice" ./core/modules/views/tests/src/Kernel/Handler/FieldTimeIntervalTest.php

As feedback:

FILE: /var/www/html/core/modules/views/tests/src/Kernel/Handler/FieldTimeIntervalTest.php
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
 37 | WARNING | Line exceeds 80 characters; contains 90 characters
 38 | WARNING | Line exceeds 80 characters; contains 109 characters
-----------------------------------------------------------------------------------------
Time: 91ms; Memory: 6MB

I've created a patch and added it to this comment. I have also added the change as a new commit to the fork created for the issue, working branch "issue-3414947-document-the-values".

BTW, I'm facing some problems with pipelines, specifically running Nightwatch (you can see the error here: https://git.drupalcode.org/issue/drupal-3414947/-/jobs/699582). It seems to be a recurring issue and not related to the changes applied here: https://www.drupal.org/project/drupal/issues/2829040 🌱 [meta] Known intermittent, random, and environment-specific test failures Active

Greetings.

πŸ‡ͺπŸ‡ΈSpain davidjguru Seville, Andalusia (Spain)

The recommended command for Linux does not seem to be working:

  $ curl -sSL https://www.drupal.org/download-latest/tar.gz | tar -xz --strip-components=1
tar: Cowardly refusing to create an empty archive
Try 'tar --help' or 'tar --usage' for more information.
curl: (23) Failed writing body (83 != 1423)
Production build 0.69.0 2024