- First commit to issue fork.
- @vhin0210 opened merge request.
- Status changed to Needs review
almost 2 years ago 1:16am 31 January 2023 - 🇮🇳India nayana_mvr
Verified the MR4 and tested it on Drupal version 9.5.x and Textfield Counter 8.x-1.x. The patch applied cleanly but with a warning
4.diff:40: trailing whitespace. Checking patch js/textfield_counter.js... Applied patch js/textfield_counter.js cleanly. warning: 1 line adds whitespace errors.
Also, there are few issues observed:-
Before applying patch
1. The counter text is shown 2 times. One below the text editor field and the other below text format field. (Screenshot attached)
After applying patch
1. The counter is updated but there is delay in updating the value.
2. The counter text is still shown 2 times. The one below the text editor field is updating the counter value while the other below text format field
remains the same. (Screenshot attached)
Note:- For Drupal version 10.1.x, Textfield Counter is not working.
- Status changed to Needs work
almost 2 years ago 4:38am 1 February 2023 - 🇮🇳India nayana_mvr
Update: Duplicating counter text is fixed with #3257307 🐛 Duplicate counter on paragraph fields Closed: duplicate
- Status changed to Needs review
almost 2 years ago 5:23am 1 February 2023 - 🇮🇳India DeepaliJ
Tested and applied MR4 #10 on Drupal version 9.5.x and 10.1.x-dev with Textfield Counter 8.x-1.x.
The patch applied cleanly.
The countdown is working fine after applying the patch
Reference videos are as per #9. - Status changed to RTBC
over 1 year ago 9:55pm 13 April 2023 - 🇺🇸United States msbtterswrth
I have tested the patch in d10.1.1 and it has fixed this issue for me. +1RTBC
- Status changed to Fixed
over 1 year ago 9:16pm 18 July 2023 -
vhin0210 →
authored 0adbe4c9 on 2.x
Issue #3267416 by vhin0210, kbriand, nayana_mvr, DeepaliJ, msbtterswrth...
-
vhin0210 →
authored 0adbe4c9 on 2.x
- Status changed to Fixed
over 1 year ago 2:46pm 19 July 2023