- Merge request !23Issue #3290964: Create drush commands to add and remove alerts. β (Merged) created by tjh
- πΊπΈUnited States edmund.dunn Olympia, WA
Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. Rerolled for 2.1. This also fixed our issue.
- πΊπΈUnited States edmund.dunn Olympia, WA
I messed up the above patch. Here's the correct one.
- Status changed to Needs review
about 1 year ago 2:30pm 31 August 2023 - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - Status changed to RTBC
about 1 year ago 3:46pm 2 October 2023 - πΊπΈUnited States tsquared212 Chicago, IL
Attesting that the proposed feature works as intended. However, I've experienced issues running the supplied functional tests for the patch--in one case, I got a "service 'lock' has a dependency on a non-existent service 'memcache.lock.factory'". And in another, "class 'Drupal\Tests\BrowserTestCase' not found" occurred. This may be due to my ignorance or possibly other factors. The patch works fine for my requirements, although I'd encourage others to review and share their experience.
- last update
12 months ago PHPLint Failed - πΊπΈUnited States edmund.dunn Olympia, WA
I had to update the patch to add an accessCheck() to the query for the getAlertsByLabel method. Missed that!
- last update
12 months ago run-tests.sh fatal error - πΊπΈUnited States edmund.dunn Olympia, WA
And missed one change for the patch.
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
12 months ago Not currently mergeable. - last update
12 months ago 8 pass, 2 fail - last update
12 months ago 14 pass - last update
12 months ago 14 pass -
ChrisSnyder β
committed f3a08e92 on 2.x authored by
tjh β
Issue #3290964 by edmund.dunn, ChrisSnyder, tjh, swirt, tsquared212:...
-
ChrisSnyder β
committed f3a08e92 on 2.x authored by
tjh β
- Status changed to Fixed
12 months ago 7:21pm 29 November 2023 - πΊπΈUnited States swirt Florida
Thank you Chris for getting this across the finish line.
Automatically closed - issue fixed for 2 weeks with no activity.