πŸ‡ΊπŸ‡ΈUnited States @tsquared212

Chicago, IL
Account created on 7 March 2023, over 1 year ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

False alarm.

The issue I discovered was in part due to an old patch.

Sorry guys.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Re-rolled patch to add guards for non-view pagers.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Attesting that the proposed feature works as intended. However, I've experienced issues running the supplied functional tests for the patch--in one case, I got a "service 'lock' has a dependency on a non-existent service 'memcache.lock.factory'". And in another, "class 'Drupal\Tests\BrowserTestCase' not found" occurred. This may be due to my ignorance or possibly other factors. The patch works fine for my requirements, although I'd encourage others to review and share their experience.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Submitted patch works, but fails a test -- Drupal\Tests\datetime\Functional\Views\FilterDateTest, due to a schema error despite numerous attempts to patch (views.pager.schema.yml).

Views Configuration Form:

Pager State after Update:

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

I think I may have a crlf issue

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Blank line was missing necessary whitespace.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

The attached patch expands on the work done in the issue fork - injecting the 'pagination_heading_level' into both full and mini pagers, as well as updating all core theme pager templates. For the life of me, I could not access 'pager_rewrite_elements' from the view config, so instead I added a method to filter out the heading elements from 'field_rewrite_elements'.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

tsquared212 β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Submitting simple patch that fixes reliance on deprecated default access check. Might be useful for those who need the changes before the @omkar_yewale PR is merged.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Submitting simple patch that fixes reliance on deprecated default access check.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

Good call, swirt.

This should roll back the changes made in Issue 3040358 - Drag table rows (https://git.drupalcode.org/project/tablefield/-/commit/26d63be6aa25d34d1...).

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

+1. Added a patch that disables the weighted rows for those who may find it useful.

πŸ‡ΊπŸ‡ΈUnited States tsquared212 Chicago, IL

+1. Adding a patch that disables the weighted data.

Production build 0.71.5 2024