- Issue created by @tsquared212
- ๐บ๐ธUnited States mglaman WI, USA
The module works on D10. Let's retitle it for the specific deprecation in the patch
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ made their first commit to this issueโs fork.
- Merge request !15Implemented ValueResolverInterface instead of ArgumentValueResolverInterface. โ (Merged) created by vishalkhode
- Status changed to Needs review
7 months ago 1:26pm 29 May 2024 - Status changed to Needs work
7 months ago 4:03pm 29 May 2024 - ๐บ๐ธUnited States mglaman WI, USA
We should implement the new interface and alias the old one.
- Status changed to Needs review
7 months ago 5:08am 31 May 2024 - ๐ฎ๐ณIndia vishalkhode
Updated the MR. CI is also passing. Re-requesting review.
-
mglaman โ
committed 389727f7 on 8.x-1.x authored by
vishalkhode โ
Issue #3362189 by vishalkhode, tsquared212, mglaman: Implement...
-
mglaman โ
committed 389727f7 on 8.x-1.x authored by
vishalkhode โ
- Status changed to Fixed
7 months ago 2:19pm 31 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฎ๐ฑIsrael jsacksick
Will open a separate issue, but this introduced a serious regression.
Because of this change, DocumentResolver::supports() is no longer invoked bySymfony\Component\HttpKernel\Controller\ArgumentResolver::getArguments()
.And as a consequence, the DocumentResolver is invoked for every request, including GET requests, throwing an exception due to an empty request body.