- Issue created by @Guicom
- Status changed to Needs review
about 1 year ago 2:32pm 29 October 2023 - Issue was unassigned.
- Assigned to christophe.klein
- Status changed to RTBC
7 months ago 2:00pm 10 May 2024 - πΊπΈUnited States greggles Denver, Colorado, USA
This looks good to me. I see the change record at https://www.drupal.org/node/3201242 β
@christophe.klein I see you assigned this to yourself. Is there something you were planning to do?
- πΊπΈUnited States bvoynick
This looks like a duplicate of https://www.drupal.org/project/paragraphs_browser/issues/3362240 π Drupal 10 compatibility fixes for Paragraphs Browser Active
- πΊπΈUnited States bvoynick
This issue is better documented though so might be better to continue here.
A little more information on this:
Omitting ->accessCheck() was only deprecated for content entities. paragraphs_browser_type is a config entity so this isn't actually a problem. But Upgrade Status thinks it is because it just sees a generic EntityStorageInterface object without a way to know if it's content or config.
This also works to make Upgrade Status happy:
$paragraphs_browser_type_storage = $this->entityTypeManager->getStorage('paragraphs_browser_type'); assert($paragraphs_browser_type_storage instanceof ConfigEntityStorageInterface); $paragraph_browser_type_ids = $paragraphs_browser_type_storage->getQuery()->execute();
But it's arguably simpler to just include the accessCheck() call as in the already-reviewed MR.
- πΊπΈUnited States tsquared212 Chicago, IL
bvoynick β credited tsquared212 β .
-
bvoynick β
committed 23008d0c on 8.x-1.x
Issue #3397513 by tsquared212, Guicom: Resolve access check error for...
-
bvoynick β
committed 23008d0c on 8.x-1.x