Patch to avoid null value by adding empty string in place to null value passed as argument.
smitghelani → created an issue.
smitghelani → created an issue.
Hi @quietone,
I understood all the concerns mentioned in old chats, but it was necessary step required in lightning_core module, as it is added as dependency patch and not working with latest Drupal versions like 10.3.x and 11.x. So, for time being or i can say till we find alternative and most promising solution for this issue, we need something to keep this thing running in our project as it is.
So, that's why added new patch to replace it in lightning_core. But, lightning_core is still bottle neck with this issue and merge request with replaced patch is also in pending to merge. So, looks like I need to find some alternative options to get rid of it.
dependency issue is taken care with this #6 patch, I faced issue while site has already installed migrate tools module without migrate plus. So, just to make double validation i am adding hook update to validate and install migrate plus if it's not installed with migrate tools.
patch downloaded from same open MR until latest version comes with changes
Open MR is already there with same fix : https://git.drupalcode.org/project/lightning_core/-/merge_requests/33
please review and merge it to get this issue fixed.
MR is there open to merge by Ilya Novikov : https://git.drupalcode.org/project/lightning_core/-/merge_requests/32
which is possible fix for this issue
smitghelani → created an issue.
Also, I will request that if someone can help to fix this issue: https://www.drupal.org/project/lightning_core/issues/3456184 🐛 AssertionError: assert($typed_config instanceof Mapping) in assert() Active with same version and facilitate it's fix release with this same upcoming release then will be best help.
smitghelani → created an issue.
smitghelani → created an issue.
Re-roll for 10.3.x branch, above one has little issue in finding file.
Re-roll for Drupal 10.3.x.
Re-roll of patch #112 with branch 10.3.x
Re-roll of patch #48 for branch 10.3.x.
With Drupal 10.2.3 and PHP version 8.2. I am also getting the same issue while applying the patch mentioned in comment #2. So, for time being i am using this patch to avoid this deprecation error,
Patch for the issue with same environment having php8.2 and drupal 10.2.3
smitghelani → created an issue.
Patch for the issue for similar platform environment and get rid of the error
smitghelani → created an issue.
In patch #12 few changes are missing due to the error while creating patch, but now i have added back those changes and it's working for module version 3.0.0 and same as patch no #8 just recreated for latest version.
Patch mentioned inside the comment #5 is not working, so refactored that patch for the module version 2.0.0.
I got the issue, it was coming from the issue https://www.drupal.org/project/drupal/issues/2771361 🐛 Ajax views leave obsolete Drupal.Ajax instances Needs work patch no #50 and inside the latest patch it is fixed. So, I am closing this issue as cannot reproduce.
Whatever I mentioned here as per that I have prepared patch.
smitghelani → created an issue.
Same patch as #3, but for me it was not working with latest version 8.x-1.0. So, Adding refactored patch here.
I have created another patch to fix this issue from the theme_permission module side, tested locally and it's working for my requirement. It's working for the version below mentioned requirements:
theme_permission: 2.0.0
Drupal core: 10.x
@lendude Thanks for your response,
I want to know more about the reason behind removing the validation which i have mentioned here inside description.
If you visit this file of drupal 9.5.x branch https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/syst... which has constructor with validations and inside drupal 10.0.x and above branches has missed this things. If i again do the same validation i am not seeing any issue from my side. this patch is doing the same thing for me.
If you can guide me more about this why the things got changed inside the latest version. I can get more clarity on this issue.
I missed the 1 thing inside the #2 patch, ModuleExtensionList $module_extension_list = NULL this parameter of function was missing to adding new patch.
As part of fix which i have mentioned above inside the description, I am recommending this patch as the fix for the error. It's providing the fix for the issue which I am getting and compatible with Drupal core 10.x branch.
smitghelani → created an issue.
Created new patch from #13, because patch #18 is not working for the latest version of module which 2.0.0-alpha7 and has some changes on tests. I am not sure about that test changes so only for the functional changes I am re-creating patch from #13. Patch here I am adding is working perfectly fine for the current latest version of the module config_update.
#42 has one code change is missing from #37,
File CandidateNodesForm.php has below mentioned change inside the #37 patch, but which is missing inside the #42 patch i have added that change and created new patch and other changes are same as #42 and tested with latest version of module 8.x-1.-rc7.
inside comment #15 i had missed 1 line to remove so adding new patch for the same.
This patch #6 is not working for the latest version 5.x, so created new patch with same code changes mentioned inside the #6. This is working for me.
Along side this issue, this #3 patch also includes resolution of below mentioned issues:
https://www.drupal.org/project/purge_akamai_optimizer/issues/3261821 →
https://www.drupal.org/project/purge_akamai_optimizer/issues/3289188 →
Also, some minor fixes that required to be applied.
Patch is only compatible with Drupal 10 branch
smitghelani → created an issue.
Supported with latest back_to_top version 3.0.0
Created patch for added condition to avoid missing value exception for web-form submission.
Create Patch to use:
https://www.drupal.org/files/issues/2023-05-01/3336053-this-can-no-longe... →