- Issue created by @smitghelani
- ๐ฎ๐ณIndia smitghelani Surat, Gujarat
As part of fix which i have mentioned above inside the description, I am recommending this patch as the fix for the error. It's providing the fix for the issue which I am getting and compatible with Drupal core 10.x branch.
- Status changed to Postponed: needs info
about 1 year ago 9:18am 14 December 2023 - ๐ณ๐ฑNetherlands Lendude Amsterdam
The fault seems to lie with AccessController in the theme_permission module that is making this call, that needs to be updated to use the correct constructor arguments.
If you switch off that module, does the error go away? If so, please open an issue for that module.
- ๐ฎ๐ณIndia smitghelani Surat, Gujarat
I missed the 1 thing inside the #2 patch,
ModuleExtensionList $module_extension_list = NULL
this parameter of function was missing to adding new patch. - ๐ฎ๐ณIndia smitghelani Surat, Gujarat
@lendude Thanks for your response,
I want to know more about the reason behind removing the validation which i have mentioned here inside description.
If you visit this file of drupal 9.5.x branch https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/syst... which has constructor with validations and inside drupal 10.0.x and above branches has missed this things. If i again do the same validation i am not seeing any issue from my side. this patch is doing the same thing for me.
If you can guide me more about this why the things got changed inside the latest version. I can get more clarity on this issue.
- Status changed to Active
about 1 year ago 11:54am 14 December 2023 - ๐ณ๐ฑNetherlands Lendude Amsterdam
It's a deprecation message.
@trigger_error('The extension.list.module service must be passed to ' . __NAMESPACE__ . '\SystemController::__construct. It was added in Drupal 8.9.0 and will be required before Drupal 10.0.0.', E_USER_DEPRECATED);
Not passing extension.list.module to the constructor is deprecated, so like the message says, before to mark your module ready for D10, you need to pass this to the constructor if you are extending SystemController, or it will break....which it did
So that module probably extends SystemController (I didn't check) and they need to update their code, so let's move the issue to that queue
- last update
about 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia smitghelani Surat, Gujarat
I have created another patch to fix this issue from the theme_permission module side, tested locally and it's working for my requirement. It's working for the version below mentioned requirements:
theme_permission: 2.0.0
Drupal core: 10.x - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- last update
12 months ago Composer require failure - Issue was unassigned.
- Status changed to Needs review
12 months ago 11:41am 20 December 2023