- 🇺🇸United States joegraduate Arizona, USA
@jhodgdon @codebymikey @Pasqualle any chance any of you might have time to review #18?
- Status changed to Needs work
over 1 year ago 9:39am 24 March 2023 - 🇭🇺Hungary pasqualle 🇭🇺 Budapest
Hi, I have checked the patch, and compared with #3143065: Default config hash is not generated for imported configuration (config_provider) →
In Configuration Provider module → the default config hash is only set when it has no value, see addDefaultConfigHash() function.
In this patch we always set the "_core" and the "default_config_hash" properties.
I am not sure if the default_config_hash should be updated at import/revert, this needs to be discussed.
The "_core" property should not be overwritten, as it might have other properties (in the future).related read:
https://www.drupal.org/node/2653358 →
https://www.drupal.org/project/drupal/issues/2656370 📌 Create a method to discover if configuration matches the shipped configuration Needs work - last update
about 1 year ago Patch Failed to Apply - 🇮🇳India smitghelani Surat, Gujarat
Created new patch from #13, because patch #18 is not working for the latest version of module which 2.0.0-alpha7 and has some changes on tests. I am not sure about that test changes so only for the functional changes I am re-creating patch from #13. Patch here I am adding is working perfectly fine for the current latest version of the module config_update.
- 🇩🇪Germany jurgenhaas Gottmadingen
- Merge request !12Issue #3056249 by mikran, joegraduate, jurgenhaas: Default config hash is not... → (Open) created by jurgenhaas
- last update
8 months ago 70 pass - 🇩🇪Germany jurgenhaas Gottmadingen
I've also turned the patch from #18 into an MR so that rebasing becomes easier in the future.