- Status changed to Needs review
over 2 years ago 7:34am 22 March 2023 - Status changed to RTBC
over 2 years ago 7:43pm 6 April 2023 - Status changed to Needs work
about 2 years ago 9:36pm 10 April 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
+++ b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php @@ -2063,7 +2063,7 @@ protected function getSharedTableFieldSchema(FieldStorageDefinitionInterface $st - throw new FieldException("Illegal field column names on {$storage_definition->getName()}"); + throw new FieldException("Illegal field column names on {$storage_definition->getName()} in {$storage_definition->getTargetEntityTypeId()} entity"); @@ -2330,7 +2330,7 @@ protected function getDedicatedTableSchema(FieldStorageDefinitionInterface $stor - throw new FieldException("Illegal field column names on {$storage_definition->getName()}"); + throw new FieldException("Illegal field column names on '{$storage_definition->getName()}' on entity type '{$storage_definition->getTargetEntityTypeId()}'");
I think we can improve this one further too, by letting the user know which column names are illegal.
Also, it would be worth making them consistent whilst we're here (one has single quotes around the field name and entity type, the other does not).
Thanks folks
- 🇮🇳India rassoni Bangalore